Bug 193744 - www/dillo2 returns with Error code 1
Summary: www/dillo2 returns with Error code 1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Brendan Fabeny
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-09-18 10:31 UTC by r004
Modified: 2014-10-04 06:53 UTC (History)
4 users (show)

See Also:
mva: maintainer-feedback-


Attachments
iconv fix (441 bytes, patch)
2014-09-18 11:11 UTC, Marcus von Appen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description r004 2014-09-18 10:31:00 UTC
www/dillo2 doesn't build and returns with the errors bellow

REENTRANT -D_THREAD_SAFE -Wall -W -Wno-unused-parameter -Waggregate-return -MT gif.o -MD -MP -MF .deps/gif.Tpo -c -o gif.o gif.c
mv -f .deps/dns.Tpo .deps/dns.Po
cc -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DDILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -O2 -pipe -fno-strict-aliasing -DENABLE_IPV6 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Wno-unused-parameter -Waggregate-return -MT jpeg.o -MD -MP -MF .deps/jpeg.Tpo -c -o jpeg.o jpeg.c
mv -f .deps/jpeg.Tpo .deps/jpeg.Po
cc -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DDILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -O2 -pipe -fno-strict-aliasing -DENABLE_IPV6 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Wno-unused-parameter -Waggregate-return -MT png.o -MD -MP -MF .deps/png.Tpo -c -o png.o png.c
mv -f .deps/png.Tpo .deps/png.Po
c++ -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DDILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -I/usr/local/include -I/usr/local/include/freetype2 -O2 -pipe -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -O2 -pipe -fno-strict-aliasing -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT imgbuf.o -MD -MP -MF .deps/imgbuf.Tpo -c -o imgbuf.o imgbuf.cc
mv -f .deps/imgbuf.Tpo .deps/imgbuf.Po
c++ -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DD
ILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -I/usr/local/include -I/usr/local/include/freetype2 -O2 -pipe -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -O2 -pipe -fno-strict-aliasing -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT image.o -MD -MP -MF .deps/image.Tpo -c -o image.o image.cc
mv -f .deps/gif.Tpo .deps/gif.Po
c++ -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DDILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -I/usr/local/include -I/usr/local/include/freetype2 -O2 -pipe -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -O2 -pipe -fno-strict-aliasing -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT menu.o -MD -MP -MF .deps/menu.Tpo -c -o menu.o menu.cc
mv -f .deps/image.Tpo .deps/image.Po
cc -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DDILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -O2 -pipe -fno-strict-aliasing -DENABLE_IPV6 -DD_DNS_THREADED -D_REENTRANT -D_THREAD_SAFE -Wall -W -Wno-unused-parameter -Waggregate-return -MT dpiapi.o -MD -MP -MF .deps/dpiapi.Tpo -c -o dpiapi.o dpiapi.c
mv -f .deps/dpiapi.Tpo .deps/dpiapi.Po
c++ -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DDILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -I/usr/local/include -I/usr/local/include/freetype2 -O2 -pipe -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -O2 -pipe -fno-strict-aliasing -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT findbar.o -MD -MP -MF .deps/findbar.Tpo -c -o findbar.o findbar.cc
mv -f .deps/findbar.Tpo .deps/findbar.Po
c++ -DHAVE_CONFIG_H -I. -I..  -I.. -DDILLO_SYSCONF='"/usr/local/etc/dillo/"' -DDILLO_DOCDIR='"/usr/local/share/doc/dillo/"'  -I/usr/local/include -I/usr/local/include/libpng15 -I/usr/local/include -I/usr/local/include/freetype2 -O2 -pipe -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -O2 -pipe -fno-strict-aliasing -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions -MT xembed.o -MD -MP -MF .deps/xembed.Tpo -c -o xembed.o xembed.cc
mv -f .deps/xembed.Tpo .deps/xembed.Po
mv -f .deps/menu.Tpo .deps/menu.Po
c++ -I/usr/local/include/libpng15 -I/usr/local/include -I/usr/local/include/freetype2 -O2 -pipe -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D
_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -O2 -pipe -fno-strict-aliasing -Wall -W -Wno-unused-parameter -fno-rtti -fno-exceptions  -Wl,-rpath,/usr/lib:/usr/local/lib -L/usr/local/lib -o dillo dillo.o paths.o tipwin.o ui.o uicmd.o bw.o cookies.o auth.o md5.o digest.o colors.o misc.o history.o prefs.o prefsparser.o keys.o url.o bitvec.o klist.o chain.o utf8.o timeout.o dialog.o web.o nav.o cache.o decode.o dicache.o capi.o domain.o css.o cssparser.o styleengine.o plain.o html.o form.o table.o bookmark.o dns.o gif.o jpeg.o png.o imgbuf.o image.o menu.o dpiapi.o findbar.o xembed.o ../dlib/libDlib.a ../dpip/libDpip.a IO/libDiof.a ../dw/libDw-widgets.a ../dw/libDw-fltk.a ../dw/libDw-core.a ../lout/liblout.a -ljpeg -L/usr/local/lib -lpng15 -L/usr/local/lib -lm -Wl,-rpath,/usr/local/lib -L/usr/ports/x11-toolkits/fltk/work/fltk-1.3.2/src -lfltk -lXext -lXft -lfontconfig -lXinerama -lpthread -lm -lX11 -lz -lX11 
decode.o: In function `a_Decode_charset_init':
decode.c:(.text+0x60c): undefined reference to `libiconv_open'
decode.o: In function `Decode_charset':
decode.c:(.text+0x71d): undefined reference to `libiconv'
decode.o: In function `Decode_charset_free':
decode.c:(.text+0x7ae): undefined reference to `libiconv_close'
form.o: In function `DilloHtmlForm::buildQueryData(DilloHtmlInput*)':
form.cc:(.text+0x2d54): undefined reference to `libiconv_open'
form.cc:(.text+0x2d90): undefined reference to `libiconv_open'
form.cc:(.text+0x3216): undefined reference to `libiconv_close'
form.o: In function `DilloHtmlForm::encodeText(void*, Dstr**)':
form.cc:(.text+0x35da): undefined reference to `libiconv'
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[5]: *** [dillo] Error 1
gmake[5]: Leaving directory `/usr/ports/www/dillo2/work/dillo-3.0.4/src'
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory `/usr/ports/www/dillo2/work/dillo-3.0.4/src'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/usr/ports/www/dillo2/work/dillo-3.0.4'
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory `/usr/ports/www/dillo2/work/dillo-3.0.4'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/www/dillo2

===>>> make build failed for www/dillo2
===>>> Aborting update

===>>> Installation of x11-toolkits/fltk (fltk-1.3.2_1) complete


===>>> You can restart from the point of failure with this command line:
       portmaster <flags> www/dillo2
Comment 1 Bugzilla Automation freebsd_committer 2014-09-18 10:31:00 UTC
Auto-assigned to maintainer bf@FreeBSD.org
Comment 2 Marcus von Appen freebsd_committer freebsd_triage 2014-09-18 11:11:16 UTC
Created attachment 147440 [details]
iconv fix

The iconv fix patch should fix the issue (it worked for me).
Comment 3 Marcus von Appen freebsd_committer freebsd_triage 2014-09-18 11:12:23 UTC
Removing ports-bugs@ from CC
Comment 4 Marcus von Appen freebsd_committer freebsd_triage 2014-09-18 11:14:05 UTC
Just (In reply to Marcus von Appen from comment #3)
> Removing ports-bugs@ from CC

Just to justify the removal: since there is a maintainer, we do not need to spam the ports-bugs@ list with each and every update to the bug.
Comment 5 r004 2014-09-18 12:49:49 UTC
So plz someone apply this to the port.
thank you
Comment 6 commit-hook freebsd_committer 2014-10-04 06:50:17 UTC
A commit references this bug:

Author: mva
Date: Sat Oct  4 06:49:59 UTC 2014
New revision: 369945
URL: https://svnweb.freebsd.org/changeset/ports/369945

Log:
  - Unbreak the build, which missed to link against iconv properly

  PR:		193744
  Submitted by:	myself
  Reported by:	roo4.id@gmail.com
  Approved by:	masintainer timeout (bf@)

Changes:
  head/www/dillo2/Makefile
Comment 7 Marcus von Appen freebsd_committer freebsd_triage 2014-10-04 06:51:04 UTC
The fix has been committed in ports 369945 (maintainer timeout 2 weeks).