Bug 193791 - [PATCH] Correctly link the .so files in x11-toolkits/blt
Summary: [PATCH] Correctly link the .so files in x11-toolkits/blt
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Some People
Assignee: Sean Bruno
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-20 09:49 UTC by Andrew Turner
Modified: 2014-09-21 15:37 UTC (History)
2 users (show)

See Also:

Attachments
Patch to use the compiler to linkthe .so files. (958 bytes, patch)
2014-09-20 09:49 UTC, Andrew Turner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Turner freebsd_committer freebsd_triage 2014-09-20 09:49:29 UTC 
Created attachment 147502 [details]
Patch to use the compiler to linkthe .so files.

The attached patch makes the x11-toolkits/blt port use cc instead of ld to link the two shared objects it creates. This fixes a problem on arm where the shared object will attempt to access symbols in libgcc, however the .so files don't link against libgcc the build fails.

With this patch I can successfully build the port on a Wandboard.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2014-09-20 12:15:15 UTC 
Feel free to commit this (with my approval if you don't have a ports commit bit).
Comment 2 Sean Bruno freebsd_committer freebsd_triage 2014-09-20 16:37:46 UTC 
Running tests on patch, will commit when done.
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2014-09-20 17:14:16 UTC 
redports build success, no impact to amd64/i386

https://redports.org/buildarchive/20140920164301-29057/
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-09-21 15:36:52 UTC 
A commit references this bug:

Author: sbruno
Date: Sun Sep 21 15:36:26 UTC 2014
New revision: 368772
URL: http://svnweb.freebsd.org/changeset/ports/368772

Log:
  Patch configure to use ${CC} instead of ld to link the two shared objects it
  creates. This fixes a problem on arm where the shared object will attempt to
  access symbols in libgcc, however the .so files don't link against libgcc the
  build fails.

  PR:		193791
  Submitted by:	andrew
  Reviewed by:	tijl
  Approved by:	bapt (mentor)

Changes:
  head/x11-toolkits/blt/files/patch-configure
Comment 5 Sean Bruno freebsd_committer freebsd_triage 2014-09-21 15:37:33 UTC 
Tested on qemu emulated builds and run through redports.  Good to go.