Bug 193801 - [NEW PORT] emulators/fs-uae-launcher
Summary: [NEW PORT] emulators/fs-uae-launcher
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-20 22:36 UTC by Uffe Jakobsen
Modified: 2014-11-04 22:00 UTC (History)
0 users

See Also:


Attachments
shar (69.75 KB, text/plain)
2014-09-20 22:36 UTC, Uffe Jakobsen
no flags Details
poudriere log (270.79 KB, text/x-log)
2014-09-20 22:36 UTC, Uffe Jakobsen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Uffe Jakobsen 2014-09-20 22:36:01 UTC
Created attachment 147514 [details]
shar

[NEW PORT] emulators/fs-uae-launcher

FS-UAE Launcher is an easy to use GUI frontend for FS-UAE

WWW: http://fs-uae.net/launcher
Comment 1 Uffe Jakobsen 2014-09-20 22:36:35 UTC
Created attachment 147515 [details]
poudriere log
Comment 2 Uffe Jakobsen 2014-10-31 09:14:42 UTC
Is there something wrong with this port ? it so please let me know and I'll correct it.
Comment 3 John Marino freebsd_committer 2014-10-31 17:24:02 UTC
nope, just nobody is reviewing PRs anymore.
This looks ok to me, poudriere log went a log way.  Moving to patch-ready status.
Comment 4 John Marino freebsd_committer 2014-11-04 16:27:42 UTC
There were a few minor issues with the makefile:

1) tabbing
2) USES was not in alphabetical order
3) compound commands where not surrounded by "()" (e.g. cd /here && do something)

You got lucky with the pkg-plist.
We have to remove all the @dirrm* lines based on new infrastructure.
However, had we still had the old one, the plist would have been unacceptable to me.  I would not accept "@dirrmtry" where "@dirrm" will work 100% of the time.  All @dirrmtry means taking output of "make makeplist" verbatim without editing which is an immediate red flag.  I'm just truncating them right now.
Comment 5 commit-hook freebsd_committer 2014-11-04 16:33:35 UTC
A commit references this bug:

Author: marino
Date: Tue Nov  4 16:32:36 UTC 2014
New revision: 372150
URL: https://svnweb.freebsd.org/changeset/ports/372150

Log:
  Add new port emulators/fs-uae-launcher

  PR:		193801
  Submitted by:	uffe

  The FS-UAE Launcher is an easy to use GUI frontend for FS-UAE, the
  free and open source Amiga Emulator based on WinUAE.

Changes:
  head/emulators/Makefile
  head/emulators/fs-uae-launcher/
  head/emulators/fs-uae-launcher/Makefile
  head/emulators/fs-uae-launcher/distinfo
  head/emulators/fs-uae-launcher/pkg-descr
  head/emulators/fs-uae-launcher/pkg-plist
Comment 6 John Marino freebsd_committer 2014-11-04 16:35:36 UTC
I also revised the text on COMMENT and pkg-descr because I didn't find them user-friendly enough for somebody that doesn't know what the port builds.

Done!
Comment 7 Uffe Jakobsen 2014-11-04 22:00:29 UTC
It was my first attempt with a larger python based port - from your comments it was not entirely a succes.

Thanks for you patience !!!

:-)