Bug 193808 - [patch] nanobsd is broken for stable/9 due to incomplete MFC
Summary: [patch] nanobsd is broken for stable/9 due to incomplete MFC
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 9.3-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Quinot
URL:
Keywords:
: 192268 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-21 11:49 UTC by Eugene Grosbein
Modified: 2014-09-30 05:55 UTC (History)
2 users (show)

See Also:

Attachments
initialize NANO_MAKE (344 bytes, patch)
2014-09-21 11:49 UTC, Eugene Grosbein 		no flags Details | Diff
patch to MFC rev 258705 (1.28 KB, patch)
2014-09-21 21:25 UTC, Thomas Quinot 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein 2014-09-21 11:49:53 UTC 
Created attachment 147523 [details]
initialize NANO_MAKE

nanobsd is broken for stable/9 since r265894 by thomas@ due to incomplete MFC that made use of new NANO_MAKE variable but forgot to initialize it.

This PR also obsoletes PR 192268 that reports the same problem but has wrong patch.
Comment 1 Thomas Quinot freebsd_committer freebsd_triage 2014-09-21 21:23:38 UTC 
Argh, sorry, obviously my MFC did not get sufficient testing.
Proper fix is to MFC rev. 258705 to stable/9. Testing now.
Comment 2 Thomas Quinot freebsd_committer freebsd_triage 2014-09-21 21:25:04 UTC 
Created attachment 147542 [details]
patch to MFC rev 258705
Comment 3 Thomas Quinot freebsd_committer freebsd_triage 2014-09-21 21:26:00 UTC 
*** Bug 192268 has been marked as a duplicate of this bug. ***
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-09-26 19:14:04 UTC 
A commit references this bug:

Author: thomas
Date: Fri Sep 26 19:13:14 UTC 2014
New revision: 272184
URL: http://svnweb.freebsd.org/changeset/base/272184

Log:
  MFC rev. 258705 to stable/9:

  Define NANO_MAKE (single threaded MAKE) and use it for installworld,
  installkernel, and distribution.

  Required in order to fix regression introduced by MFC rev. 265894
  for kern/162736, since that change depends on this one.

  PR:		193808

Changes:
  stable/9/tools/tools/nanobsd/nanobsd.sh
Comment 5 Thomas Quinot freebsd_committer freebsd_triage 2014-09-26 19:14:53 UTC 
Should be fixed in rev. 272184, please confirm.
Comment 6 Eugene Grosbein 2014-09-30 05:55:40 UTC 
Confirmed, the problem is fixed. Thank you.