Bug 193816 - net/turnserver is out of date
Summary: net/turnserver is out of date
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-21 17:40 UTC by Bradley T. Hughes
Modified: 2014-09-23 21:56 UTC (History)
3 users (show)

See Also:
mom040267: maintainer-feedback+


Attachments
Patch to upgrade net/turnserver (3.55 KB, text/plain)
2014-09-21 17:40 UTC, Bradley T. Hughes
no flags Details
This is the patch that updates from 3.2.2.5 to the latest 3.2.4.4 version (4.15 KB, patch)
2014-09-22 02:04 UTC, mom040267
mom040267: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley T. Hughes freebsd_committer freebsd_triage 2014-09-21 17:40:35 UTC
Created attachment 147530 [details]
Patch to upgrade net/turnserver

The version in ports is 3.2.2.5, while the latest version is 3.2.4.4 Attached is a patch to upgrade the version in ports.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-21 17:40:35 UTC
Maintainer CC'd
Comment 2 mom040267 2014-09-22 02:00:07 UTC
I am the maintainer of the net/turnserver and I approve the change. The only problem is that the manpages are broken in the proposed patch. I am going to attach a fixed patch (from 3.2.2.5 to 3.2.4.4) with fixed manpages.

Please go ahead with the change - commit the changes.

Thanks
Oleg
Comment 3 mom040267 2014-09-22 02:04:00 UTC
Created attachment 147545 [details]
This is the patch that updates from 3.2.2.5 to the latest 3.2.4.4 version

This patch is doing the same as the patch proposed by bradleythughes (thanks to him a lot) - but it additionally fixes the manpages of the port. I am the maintainer so I am automatically approving the change :)
Comment 4 mom040267 2014-09-22 02:06:21 UTC
I tested my patch on the redports (FreeBSD versions from 8.4 to 11) - and it works fine.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-09-23 21:53:23 UTC
A commit references this bug:

Author: mandree
Date: Tue Sep 23 21:53:18 UTC 2014
New revision: 369125
URL: http://svnweb.freebsd.org/changeset/ports/369125

Log:
  Update to new upstream version 3.2.4.4 [1], avoiding manpage regression [2].

  Minor changes over PR:
  1. @dirrmtry -> @dir, removing trailing slashes from @dirrmtry
     include/turn/client/ (else "make uninstall" complains - this is not
     checked/found by "make check-plist"!)

  2. added :prog and :xdocs-labels to MASTER_SITES and DISTFILES to avoid
     fetching files from the wrong directories.

  PR:		193816
  Submitted by:	bradleythughes@fastmail.fm [1],  mom040267@gmail.com [2]
  Approved by:	mom040267@gmail.com (maintainer)

Changes:
  head/net/turnserver/Makefile
  head/net/turnserver/distinfo
  head/net/turnserver/pkg-plist
Comment 6 Matthias Andree freebsd_committer freebsd_triage 2014-09-23 21:56:51 UTC
Committed, thanks for submissions, reviews and a rather clean experience. -- 

Please read the commit message in the previous comment for minor changes I had to make so you can do them on your next port updates if necessary.

It is a good idea to run "make check-plist package install uninstall", or a "poudriere testport", to check for harder-to-find errors, and it is also suggested that DEVELOPER=yes be set temporarily in /etc/make.conf while hacking on ports yourself.

(You may need to disable DEVELOPER=yes again for large-scale source-based port upgrades, some ports don't build with it.)