Bug 193868 - [PATCH] x11-clocks/asclock-gtk Fix staging and other fixes
Summary: [PATCH] x11-clocks/asclock-gtk Fix staging and other fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-23 11:00 UTC by Guido Falsi
Modified: 2014-10-13 10:15 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback? (kuriyama)

Attachments
asclock-gtk.diff (10.24 KB, patch)
2014-09-23 11:00 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2014-09-23 11:00:31 UTC 
Created attachment 147592 [details]
asclock-gtk.diff

A friend of mine (riccardo at torrini.org) asked me help because the port in summary had problems for him.

I discovered the port was improperly converted to staging.

I also:

- modified the port to take advantage of the OPTIONS framework, instead of interactively querying for a theme.

- Found out various non default themes generated errors when compiled with clang, fixed those

- While here removed @dirrms, which are not needed anymore as of pkg-1.3.8.

I'd like to get the attached patch approved. Thanks.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-23 11:00:31 UTC 
Auto-assigned to maintainer kuriyama@FreeBSD.org
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2014-10-07 18:17:37 UTC 
Hi, Have you had time to take a look at this?

The PR is near to timeout.

Thanks.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2014-10-13 10:15:21 UTC 
Committed due to timeout.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-10-13 10:15:58 UTC 
A commit references this bug:

Author: madpilot
Date: Mon Oct 13 10:14:57 UTC 2014
New revision: 370761
URL: https://svnweb.freebsd.org/changeset/ports/370761

Log:
  - Convert theme selection menu to use OPTIONS framework
  - Fix build of non default themes with clang
  - Remove unecessary RM

  PR:		193868
  Submitted by:	me
  Approved by:	maintainer timeout

Changes:
  head/x11-clocks/asclock-gtk/Makefile
  head/x11-clocks/asclock-gtk/files/patch-themes__Freeamp__beats.xpm
  head/x11-clocks/asclock-gtk/files/patch-themes__Freeamp__hour.xpm
  head/x11-clocks/asclock-gtk/files/patch-themes__Freeamp__minute.xpm
  head/x11-clocks/asclock-gtk/files/patch-themes__Freeamp__second.xpm
  head/x11-clocks/asclock-gtk/files/patch-themes__analog__led.xpm
  head/x11-clocks/asclock-gtk/files/patch-themes__beats__led.xpm
  head/x11-clocks/asclock-gtk/files/patch-themes__shaped__led.xpm