Bug 193921 - misc/logsurfer: /usr/local/etc/rc.d/logsurfer: /var/log/messages: Permission denied
Summary: misc/logsurfer: /usr/local/etc/rc.d/logsurfer: /var/log/messages: Permission ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-25 10:00 UTC by Marcin Cieślak
Modified: 2018-01-12 14:03 UTC (History)
2 users (show)

See Also:


Attachments
svn-diff-logsurfer (799 bytes, patch)
2018-01-12 13:33 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Cieślak 2014-09-25 10:00:17 UTC
RC script adds (non-existing by default) config file and the system log file into "required_files".

In the current RC infrastructure, required_files are checked regardless whether the service is enabled, therefore default settings after installation cause

/usr/local/etc/rc.d/logsurfer: /var/log/messages: Permission denied 

on startup
Comment 1 Bugzilla Automation freebsd_committer 2014-09-25 10:00:17 UTC
Maintainers CC'd
Comment 2 pbd 2015-11-25 09:04:56 UTC
I would rather say, that required_files definition in logsurger's RC script needs to be double-quoted:

required_files="${logsurfer_config} ${logsurfer_logfile}"

Without the qoutes, logsurfer would not start, even if both files exist.
Comment 3 Walter Schwarzenfeld freebsd_triage 2018-01-12 13:33:17 UTC
Created attachment 189649 [details]
svn-diff-logsurfer
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-01-12 13:33:38 UTC
Maintainer timeout!
Comment 5 commit-hook freebsd_committer 2018-01-12 14:03:30 UTC
A commit references this bug:

Author: zi
Date: Fri Jan 12 14:02:49 UTC 2018
New revision: 458827
URL: https://svnweb.freebsd.org/changeset/ports/458827

Log:
  - Add missing quotes to rc script

  PR:		193921
  Submitted by:	saper@saper.info

Changes:
  head/misc/logsurfer/Makefile
  head/misc/logsurfer/files/logsurfer.in