Bug 194097 - [patch update] glassfish-4.1
Summary: [patch update] glassfish-4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-02 16:10 UTC by Enrico M. Crisostomo
Modified: 2014-10-15 17:37 UTC (History)
2 users (show)

See Also:
cjr: maintainer-feedback+


Attachments
glassfish-4.1 update - SVN port diff (137.89 KB, patch)
2014-10-02 16:10 UTC, Enrico M. Crisostomo
enrico.m.crisostomo: maintainer-approval+
Details | Diff
glassfish-4.1 update - SVN port diff - Update 2 (137.93 KB, patch)
2014-10-15 16:26 UTC, Enrico M. Crisostomo
enrico.m.crisostomo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrico M. Crisostomo 2014-10-02 16:10:10 UTC
Created attachment 147918 [details]
glassfish-4.1 update - SVN port diff

I've contacted the current glassfish port maintainer and he agrees on my submitting this port update.

Attached you can find the svn diff.
Comment 1 Enrico M. Crisostomo 2014-10-02 21:25:09 UTC
Comment on attachment 147918 [details]
glassfish-4.1 update - SVN port diff

Maintainer agreed on my submitting the patch.
Comment 2 Kurt Jaeger freebsd_committer 2014-10-15 10:37:14 UTC
I'm running poudriere test builds right now.
Comment 3 Enrico M. Crisostomo 2014-10-15 16:24:27 UTC
Hi Kurt,

Thank you very much for progressing on this PR.

Today I had to update this port because I found a bug and an improvement in the rc script: since the status is still "In Discussion", and since it's my very first port update, I hope you don't mind my doing this and attaching another svn patch (if I'm skipping some rule here, I'm not aware of it.)

Thanks you and regards,
-- 
Enrico
Comment 4 Enrico M. Crisostomo 2014-10-15 16:26:31 UTC
Created attachment 148343 [details]
glassfish-4.1 update - SVN port diff - Update 2

Fixes an hardcoded path in the rc script.
Uses JAVA_HOME in the PATH instead of hard-coding /usr/local/bin.
Comment 5 commit-hook freebsd_committer 2014-10-15 17:25:45 UTC
A commit references this bug:

Author: pi
Date: Wed Oct 15 17:25:27 UTC 2014
New revision: 370937
URL: https://svnweb.freebsd.org/changeset/ports/370937

Log:
  www/glassfish: 3.1.2.2 -> 4.1

  Changes since 3.1.2.2:
  https://glassfish.java.net/docs/4.0/release-notes.pdf
  https://glassfish.java.net/docs/4.1/release-notes.pdf

  PR:		194097
  Submitted by:	Enrico M. Crisostomo <enrico.m.crisostomo@gmail.com>
  Approved by:	cjr@cruwe.de (maintainer)

Changes:
  head/www/glassfish/Makefile
  head/www/glassfish/distinfo
  head/www/glassfish/files/glassfish.in
  head/www/glassfish/pkg-plist
Comment 6 Kurt Jaeger freebsd_committer 2014-10-15 17:30:38 UTC
(In reply to Enrico M. Crisostomo from comment #4)
> Created attachment 148343 [details]
> glassfish-4.1 update - SVN port diff - Update 2
> 
> Fixes an hardcoded path in the rc script.
> Uses JAVA_HOME in the PATH instead of hard-coding /usr/local/bin.

Thanks, I used the updated patch, tested with poudriere, everythink
looks fine, so: Committed.
Comment 7 Enrico M. Crisostomo 2014-10-15 17:37:58 UTC
Thank you very much Kurt.