Bug 194167 - graphics/pixie: Fix build on 8.x/9.x
Summary: graphics/pixie: Fix build on 8.x/9.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
Keywords: needs-qa, patch
Depends on:
Reported: 2014-10-05 18:32 UTC by tkato432
Modified: 2015-02-06 19:52 UTC (History)
1 user (show)

See Also:

graphics_pixie.diff (2.18 KB, patch)
2014-10-05 18:32 UTC, tkato432
no flags Details | Diff
graphics_pixie.diff (1.87 KB, patch)
2014-10-18 12:31 UTC, tkato432
no flags Details | Diff
graphics_pixie.diff (3.23 KB, patch)
2015-01-27 10:00 UTC, tkato432
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2014-10-05 18:32:35 UTC
Created attachment 148007 [details]
Comment 1 tkato432 2014-10-18 12:31:03 UTC
Created attachment 148429 [details]
Comment 2 John Marino freebsd_committer 2014-10-23 15:46:56 UTC
why the change on lines 61-64?
They don't do anything different and as far as I am concerned the original approach is better.  (e.g. avoid loops if its possible, and this created a loop for no decent reason)
Comment 3 John Marino freebsd_committer 2014-10-31 14:31:00 UTC
Comment 4 Antoine Brodin freebsd_committer 2014-11-11 09:20:03 UTC
also the patch doesn't fix the build for me
Comment 5 John Marino freebsd_committer 2015-01-26 07:23:04 UTC
There's been no response from submitter since mid-november and it doesn't fix the build as advertised (according to antoine) so I'm closing the PR without further action.
Comment 6 John Marino freebsd_committer 2015-01-26 07:23:51 UTC
(more accurately there was no response since mid october)
Comment 7 tkato432 2015-01-27 10:00:39 UTC
Created attachment 152255 [details]

It seems this port also doesn't build with 9.x at present.
Comment 8 tkato432 2015-01-27 10:02:03 UTC
Comment 9 commit-hook freebsd_committer 2015-02-06 19:49:04 UTC
A commit references this bug:

Author: marino
Date: Fri Feb  6 19:48:09 UTC 2015
New revision: 378551
URL: https://svnweb.freebsd.org/changeset/ports/378551

  graphics/pixie: Fix build on F9

  PR:		194167
  Submitted by:	Ports Fury

Comment 10 John Marino freebsd_committer 2015-02-06 19:52:29 UTC
Thanks.  I removed the unnecessary changes and tested it on FreeBSD 9 successfully.