Bug 194193 - [maintainer patch] deskutils/fet update to 5.23.3
Summary: [maintainer patch] deskutils/fet update to 5.23.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-06 16:54 UTC by Zsolt Udvari
Modified: 2014-10-17 17:00 UTC (History)
2 users (show)

See Also:

Attachments
patch (1.87 KB, patch)
2014-10-06 16:54 UTC, Zsolt Udvari 		no flags Details | Diff
Updated patch (1.79 KB, patch)
2014-10-07 16:39 UTC, Zsolt Udvari 		no flags Details | Diff
Deleted dirrm lines (2.03 KB, patch)
2014-10-10 13:43 UTC, Zsolt Udvari 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Udvari freebsd_committer freebsd_triage 2014-10-06 16:54:41 UTC 
Created attachment 148036 [details]
patch

udated to 5.23.3
remove fet.1 manpage

Redports log: https://redports.org/buildarchive/20141002185417-37506/
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2014-10-07 15:58:07 UTC 
Why's manpage no longer installed? I'd also install new docs. Also, maybe cli only mode doesn't need GUI Qt dependencies?
Comment 2 Zsolt Udvari freebsd_committer freebsd_triage 2014-10-07 16:39:00 UTC 
No, cli-only-mode needs QtDialog too (see https://redports.org/~uzsolt/20141007161912-23924-251193/fet-5.23.3.log ). Maybe can patch to solve this but now I haven't time.

Manual: it was my stupidity. Manual pages moved from 'doc' to new 'man' directory and I didn't notice it. Sorry. The updated patch uploaded.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2014-10-07 16:39:30 UTC 
Created attachment 148073 [details]
Updated patch
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-08 18:51:11 UTC 
Zsolt, you need to remove @dirrm lines from pkg-plist.
In the future (starting with next patch), provide a poudriere test log that shows stage-qa check with every PR.  Those get taken first.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2014-10-10 13:43:13 UTC 
Created attachment 148165 [details]
Deleted dirrm lines
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-10-17 17:00:11 UTC 
A commit references this bug:

Author: pawel
Date: Fri Oct 17 16:59:49 UTC 2014
New revision: 371070
URL: https://svnweb.freebsd.org/changeset/ports/371070

Log:
  - Update to version 5.23.3
  - Remove @dirrm's from pkg-plist

  PR:		194193
  Submitted by:	maintainer

Changes:
  head/deskutils/fet/Makefile
  head/deskutils/fet/distinfo
  head/deskutils/fet/pkg-plist