Bug 194214 - latest lang/erlang OTP 17.3 breaks against many https calls
Summary: latest lang/erlang OTP 17.3 breaks against many https calls
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jimmy Olgeni
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2014-10-07 11:36 UTC by Dave Cottlehuber
Modified: 2014-10-09 12:54 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Cottlehuber freebsd_committer freebsd_triage 2014-10-07 11:36:51 UTC 
Upstream issue noted at http://erlang.org/pipermail/erlang-questions/2014-September/081176.html is pretty serious, breaking cowboy, httpc and almost every other SSL-using app for many common sites.

Simple fix is to include the patch from https://github.com/erlang/otp/commit/b196730a325cfe74312c3a5f4b1273ba7c705ed6.diff which will be rolled into the next OTP release.

failing test is:

```
application:ensure_all_started(ssl).
application:ensure_all_started(inets).
httpc:request("https://freebsd.org/").
```
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-08 17:35:10 UTC 
This didn't get auto-assigned because lang/erlang wasn't in the title
Comment 2 Jimmy Olgeni freebsd_committer freebsd_triage 2014-10-08 17:49:44 UTC 
Checking right now...
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-09 12:49:10 UTC 
A commit references this bug:

Author: olgeni
Date: Thu Oct  9 12:48:32 UTC 2014
New revision: 370520
URL: https://svnweb.freebsd.org/changeset/ports/370520

Log:
  Fix SSL handshake when SNI-extension is empty.

  While I'm here:

  - Reduce diff with the main Erlang port
  - Do not mute install commands

  PR:		194214
  Submitted by:	Dave Cottlehuber

Changes:
  head/lang/erlang-runtime17/Makefile
  head/lang/erlang-runtime17/files/patch-lib_ssl_src_ssl__handshake.erl
  head/lang/erlang-runtime17/files/patch-lib_ssl_test_ssl__handshake__SUITE.erl
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-10-09 12:51:12 UTC 
A commit references this bug:

Author: olgeni
Date: Thu Oct  9 12:50:56 UTC 2014
New revision: 370521
URL: https://svnweb.freebsd.org/changeset/ports/370521

Log:
  Fix SSL handshake when SNI-extension is empty.

  While I'm here:

  - Cleanup plist
  - Unmute an install command

  PR:		194214
  Submitted by:	Dave Cottlehuber

Changes:
  head/lang/erlang/Makefile
  head/lang/erlang/files/patch-lib_ssl_src_ssl__handshake.erl
  head/lang/erlang/files/patch-lib_ssl_test_ssl__handshake__SUITE.erl
  head/lang/erlang/pkg-plist
Comment 5 Jimmy Olgeni freebsd_committer freebsd_triage 2014-10-09 12:54:24 UTC 
Fixed, thank you!