Bug 194230 - [NEW PORT] devel/p5-Router-R3 - XS wrapper around a C library R3
Summary: [NEW PORT] devel/p5-Router-R3 - XS wrapper around a C library R3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-10-07 19:24 UTC by Gasol Wu
Modified: 2015-02-08 21:31 UTC (History)
2 users (show)

See Also:

Attachments
shell archive (1.93 KB, patch)
2014-11-10 15:26 UTC, Gasol Wu 		no flags Details | Diff
poudriere test log (20.63 KB, text/plain)
2014-11-10 15:27 UTC, Gasol Wu 		no flags Details
shell archive (2.27 KB, text/plain)
2014-11-13 10:36 UTC, Gasol Wu 		no flags Details
poudriere log (20.59 KB, text/plain)
2014-11-13 10:38 UTC, Gasol Wu 		no flags Details
shell archive (2.25 KB, text/plain)
2014-11-13 10:54 UTC, Gasol Wu 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gasol Wu 2014-10-07 19:24:17 UTC 
R3 is an URL router library with high performance, thus, it's implemented in C.
It compiles your route paths into a prefix trie.

By using the constructed prefix trie in the start-up time, you can dispatch
routes with efficiency.

WWW: http://search.cpan.org/dist/Router-R3/

--

Depends on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194212
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-31 19:05:10 UTC 
There's no attachment here.

Also, don't forget to attach the poudriere test log too.
Comment 2 Gasol Wu 2014-11-10 15:26:39 UTC 
Created attachment 149263 [details]
shell archive
Comment 3 Gasol Wu 2014-11-10 15:27:12 UTC 
Created attachment 149264 [details]
poudriere test log
Comment 4 John Marino freebsd_committer freebsd_triage 2014-11-10 15:49:01 UTC 
everything is okay except for how shar is generated.

https://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html

Specifically, "Next, build the shar(1) file. Assuming the port is called oneko, cd to the directory above where the oneko directory is located, and then type: shar `find oneko` > oneko.shar"

You generated it in the directory itself, it needs to be above the p5-Router-R3 directory at least.
Comment 5 Gasol Wu 2014-11-13 10:36:46 UTC 
Created attachment 149367 [details]
shell archive

- Remove cvs tag
- Strip shared library
Comment 6 Gasol Wu 2014-11-13 10:38:37 UTC 
Created attachment 149368 [details]
poudriere log
Comment 7 John Marino freebsd_committer freebsd_triage 2014-11-13 10:41:40 UTC 
Comment on attachment 149367 [details]
shell archive

remove "patch" attribute, this is a shar file
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-13 10:42:49 UTC 
there's only one problem.  Fix it and I'll promote:

"@${STRIP_CMD} ${STAGEDIR}${SITE_PERL}/${PERL_ARCH}/auto/Router/R3/R3.so"

remove "@" symbol.  We don't suppress installation commands.
Comment 9 Gasol Wu 2014-11-13 10:54:14 UTC 
Created attachment 149370 [details]
shell archive

- Remove @ symbol putting in front of $STRIP_CMD.
Comment 10 John Marino freebsd_committer freebsd_triage 2014-11-13 10:57:00 UTC 
Thanks!  I'm assigning this patch-ready port to perl@ group.
Comment 11 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-08 21:14:34 UTC 
Testing @work.
Comment 12 commit-hook freebsd_committer freebsd_triage 2015-02-08 21:30:43 UTC 
A commit references this bug:

Author: pi
Date: Sun Feb  8 21:30:29 UTC 2015
New revision: 378688
URL: https://svnweb.freebsd.org/changeset/ports/378688

Log:
  New port: devel/p5-Router-R3

  R3 is an URL router library with high performance, thus, it's
  implemented in C. It compiles your route paths into a prefix trie.

  By using the constructed prefix trie in the start-up time, you can
  dispatch routes with efficiency.

  WWW: http://search.cpan.org/dist/Router-R3/

  PR:		194230
  Submitted by:	Gasol Wu <gasol.wu@gmail.com>
  Reviewed by:	marino

Changes:
  head/devel/Makefile
  head/devel/p5-Router-R3/
  head/devel/p5-Router-R3/Makefile
  head/devel/p5-Router-R3/distinfo
  head/devel/p5-Router-R3/pkg-descr
  head/devel/p5-Router-R3/pkg-plist
Comment 13 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-08 21:31:13 UTC 
Committed, thanks. And thank you for your patience.