Bug 194234 - [ixgbe] Update ixgbe to 2.5.27
Summary: [ixgbe] Update ixgbe to 2.5.27
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-net (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-07 23:41 UTC by Eric Joyner
Modified: 2015-01-28 01:38 UTC (History)
6 users (show)

See Also:


Attachments
Core code patch (16.30 KB, patch)
2014-10-07 23:41 UTC, Eric Joyner
no flags Details | Diff
Shared code patch (145.69 KB, patch)
2014-10-07 23:42 UTC, Eric Joyner
no flags Details | Diff
Patch for the core code -- ixgbe.[ch], ixv.[ch], ixgbe_osdep.h (17.30 KB, patch)
2014-10-23 22:50 UTC, Eric Joyner
no flags Details | Diff
Patch for the shared code -- every other non-core source file (159.29 KB, patch)
2014-10-23 22:51 UTC, Eric Joyner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Joyner 2014-10-07 23:41:58 UTC
Created attachment 148084 [details]
Core code patch

Core changes:
- Fix to IXGBE_LEGACY_TX so it builds properly
  - Added commented-out options to Makefile for IXGBE_LEGACY_BUILD support,
    for builds on FreeBSD 7/8. This hasn't been tested thoroughly, though.
- Wrap some counter(9) code in driver in __FreeBSD_version >= 1100036 defines so that there is still stats support in older versions of FreeBSD
  - Most of this is derived from r272227 for ixl/v(4)
- Move SIOCGI2C ioctl under __FreeBSD_version >= 1100036 define as well
- Two new device IDs

Shared code changes:
- Primarily changes to support upcoming 10 gig products and bug fixes.
Comment 1 Eric Joyner 2014-10-07 23:42:28 UTC
Created attachment 148085 [details]
Shared code patch

Attaching second patch
Comment 2 Eric Joyner 2014-10-16 20:03:03 UTC
I'll re-submit a core code patch; John Baldwin made valid comments about some parts of it.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2014-10-20 01:46:52 UTC
Over to maintainers.
Comment 4 Eric Joyner 2014-10-23 22:50:41 UTC
Created attachment 148597 [details]
Patch for the core code -- ixgbe.[ch], ixv.[ch], ixgbe_osdep.h
Comment 5 Eric Joyner 2014-10-23 22:51:46 UTC
Created attachment 148598 [details]
Patch for the shared code -- every other non-core source file
Comment 6 Eric Joyner 2014-10-23 22:53:14 UTC
I've attached two updated patches, in svn diff format.

The shared code patch is just a more recent version of the previous one I submitted; still more updates to prepare for support for new adapters.

The v2 core code patch adds a new change -- I moved ether_ifdetach() up in ixgbe_attach(), and removed the clearing of IFF_UP since the move solved that issue.
Comment 7 Adrian Chadd freebsd_committer freebsd_triage 2014-10-23 23:04:11 UTC
Ok, I'll take a look at it tonight/tomorrow and give it some basic testing.

Thanks!


-adrian
Comment 8 Eric Joyner 2015-01-28 01:38:55 UTC
A newer patch to update ixgbe (that obsoletes this one) has been posted in phabricator:

https://reviews.freebsd.org/D1580