Bug 194291 - grdc shows 12 AM at noon
Summary: grdc shows 12 AM at noon
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.0-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-10 18:17 UTC by mlsemon35
Modified: 2015-09-24 19:43 UTC (History)
1 user (show)

See Also:

Attachments
patch to let grdc show PM instead of AM during the 12 PM hour (379 bytes, patch)
2014-10-10 18:17 UTC, mlsemon35 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mlsemon35 2014-10-10 18:17:20 UTC 
Created attachment 148175 [details]
patch to let grdc show PM instead of AM during the 12 PM hour

When I use `grdc -t`, it shows 12:00:00 AM at noon.  I keep dragging this patch along and using it.  IOW, I patch it like this:

cd /usr/src/games/grdc
patch < grdc-noon-patch.diff

I don't know when this became the case, or whether I noticed it first in FreeBSD 9.2 or in 10.0.

Thanks!

Michael
Comment 1 commit-hook freebsd_committer freebsd_triage 2015-06-02 20:54:08 UTC 
A commit references this bug:

Author: emaste
Date: Tue Jun  2 20:53:18 UTC 2015
New revision: 283929
URL: https://svnweb.freebsd.org/changeset/base/283929

Log:
  Correct grdc(1) 12-hour display between 12:00 and 13:00

  PM starts at 12:00, not 13:00.

  PR:		194291, 200133
  Submitted by:	Nick Price
  MFC after:	1 week

Changes:
  head/games/grdc/grdc.c
Comment 2 mlsemon35 2015-06-20 23:20:27 UTC 
Hmmm, there might be a different fix in last night's 11-CURRENT i386 snapshot, or at least grdc seems to be working OK there in limited testing.  No worries if you have to junk this patch:  It was coded very quickly during a lunch break at work.

Thanks!

Michael
Comment 3 Ed Maste freebsd_committer freebsd_triage 2015-06-21 15:59:12 UTC 
> Hmmm, there might be a different fix in last night's 11-CURRENT i386 snapshot, or at least grdc seems to be working OK there in limited testing.  No worries if you have to junk this patch:  It was coded very quickly during a lunch break at work.

I found PR 200133 first and committed a version of the patch from that one. It should be equivalent to the change here, just written a bit differently.

Thanks for the bug report and patch, and sorry it wasn't spotted earlier. I'm leaving this PR open until the fix is MFC'd.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-09-24 19:37:46 UTC 
A commit references this bug:

Author: emaste
Date: Thu Sep 24 19:37:35 UTC 2015
New revision: 288185
URL: https://svnweb.freebsd.org/changeset/base/288185

Log:
  MFC r283929: Correct grdc(1) 12-hour display between 12:00 and 13:00

  PM starts at 12:00, not 13:00.

  PR:		194291, 200133
  Submitted by:	Nick Price

Changes:
_U  stable/10/
  stable/10/games/grdc/grdc.c
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-09-24 19:42:49 UTC 
A commit references this bug:

Author: emaste
Date: Thu Sep 24 19:42:32 UTC 2015
New revision: 288186
URL: https://svnweb.freebsd.org/changeset/base/288186

Log:
  MFC r283929: Correct grdc(1) 12-hour display between 12:00 and 13:00

  PM starts at 12:00, not 13:00.

  PR:		194291, 200133
  Submitted by:	Nick Price

Changes:
_U  stable/9/games/grdc/
  stable/9/games/grdc/grdc.c