Bug 194303 - [PATCH] mail/trojita: Remove dependency on devel/qt5-qmldevtools
Summary: [PATCH] mail/trojita: Remove dependency on devel/qt5-qmldevtools
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-11 17:58 UTC by Raphael Kubo da Costa
Modified: 2014-10-13 18:35 UTC (History)
2 users (show)

See Also:
marco.broeder: maintainer-feedback+


Attachments
Proposed patch (647 bytes, patch)
2014-10-11 17:58 UTC, Raphael Kubo da Costa
rakuco: maintainer-approval? (marco.broeder)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer 2014-10-11 17:58:32 UTC
Created attachment 148198 [details]
Proposed patch

mail/trojita does not actually need that port, as it does not use the libraries or the private headers at all.

The attached patch removes the dependency and bumps PORTREVISION.
Comment 1 Bugzilla Automation freebsd_committer 2014-10-11 17:58:32 UTC
Maintainers CC'd
Comment 2 Marco Bröder 2014-10-13 17:14:54 UTC
You are right. The patch is fine. Tested on amd64 stable/10 and stable/9. Please commit.

Thank you!
Comment 3 commit-hook freebsd_committer 2014-10-13 18:31:51 UTC
A commit references this bug:

Author: rakuco
Date: Mon Oct 13 18:31:25 UTC 2014
New revision: 370813
URL: https://svnweb.freebsd.org/changeset/ports/370813

Log:
  Remove build-time dependency on devel/qt5-qmldevtools.

  qt5-qmldevtools is likely to be removed when we move to Qt 5.3, and trojita
  has never actually needed it.

  PR:		194303
  Approved by:	Marco Broeder <marco.broeder@posteo.eu> (maintainer)

Changes:
  head/mail/trojita/Makefile
Comment 4 Raphael Kubo da Costa freebsd_committer 2014-10-13 18:35:45 UTC
Committed, thanks for the fast approval!