Bug 194518 - x11/slim: man page references an incorrect path
Summary: x11/slim: man page references an incorrect path
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 20:34 UTC by Adrian Chadd
Modified: 2014-11-02 09:44 UTC (History)
2 users (show)

See Also:

Attachments
man page fixes (1.83 KB, patch)
2014-11-01 11:25 UTC, Guido Falsi 		madpilot: maintainer-approval? (henry.hu.sh)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Chadd freebsd_committer freebsd_triage 2014-10-21 20:34:18 UTC 
The slim port manpage has an example that references /usr/share/slim/themes/default which isn't valid for FreeBSD. The themes are in /usr/local/share/slim/themes/default .

Thanks!


-adrian
Comment 1 John Marino freebsd_committer freebsd_triage 2014-11-01 10:48:46 UTC 
fix abuse of square brackets in title which also prevented maintainer from being CC'd (and CC him now)
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2014-11-01 11:19:30 UTC 
I noticed also another wrong path. I'm going to attach a patch shortly.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2014-11-01 11:25:48 UTC 
Created attachment 148863 [details]
man page fixes

Can you(maintainer) approve this patch?

I'd like to commit it together with bug 194252

Thanks!
Comment 4 Henry Hu 2014-11-01 22:01:39 UTC 
I'm ok with other changes, but do you really put slim_enable="YES" in /usr/local/etc/rc.conf? Put everything in /etc/rc.conf seems to be easier to maintain.
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2014-11-02 09:38:09 UTC 
(In reply to Henry Hu from comment #4)
> I'm ok with other changes, but do you really put slim_enable="YES" in
> /usr/local/etc/rc.conf? Put everything in /etc/rc.conf seems to be easier to
> maintain.

You're right. I "overpatched". I'm going to commit the patch afteer fixing this mistake.

Thanks!
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2014-11-02 09:44:32 UTC 
Committed. Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-11-02 09:44:55 UTC 
A commit references this bug:

Author: madpilot
Date: Sun Nov  2 09:44:03 UTC 2014
New revision: 372060
URL: https://svnweb.freebsd.org/changeset/ports/372060

Log:
  - Modify sample config to not listen on the net by default [1]
  - Fix paths in man page [2]
  - While here, silence some portlint warnings and modernize plist

  PR:		194252 [1], 194518 [2]
  Submitted by:	uffe at uffe.org [1]
  			adrian@ [2]
  Approved by:	Henry Hu <henry.hu.sh at gmail.com> (maintainer)

Changes:
  head/x11/slim/Makefile
  head/x11/slim/files/patch-slim.1
  head/x11/slim/files/patch-slim.conf
  head/x11/slim/pkg-plist