Bug 194579 - [maintainer-update] [patch] net/rabbitmq-c-devel: update to v0.5.2
Summary: [maintainer-update] [patch] net/rabbitmq-c-devel: update to v0.5.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-24 15:12 UTC by Geoff Garside
Modified: 2014-11-07 19:33 UTC (History)
3 users (show)

See Also:
rabbitmq: maintainer-feedback+


Attachments
net/rabbitmq-c-devel v0.5.2 patch (1.49 KB, patch)
2014-10-24 15:12 UTC, Geoff Garside
no flags Details | Diff
patch with maintainer address change (1.63 KB, patch)
2014-10-24 15:14 UTC, Geoff Garside
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff Garside 2014-10-24 15:12:28 UTC
Created attachment 148618 [details]
net/rabbitmq-c-devel v0.5.2 patch

Update net/rabbitmq-c-devel to v0.5.2

Poudriere testport against this and the net/pecl-amqp port reported successful installation and cleanup of both.

Maintainer address rabbitmq@ this is an alias of this freebsd@ account.

Apologies for how poorly I've maintained this port thus far, I am trying to improve myself.
Comment 1 Bugzilla Automation freebsd_committer 2014-10-24 15:12:28 UTC
Maintainer CC'd
Comment 2 Geoff Garside 2014-10-24 15:14:58 UTC
Created attachment 148619 [details]
patch with maintainer address change

Another option might be updating the maintainer address to the freebsd@ address, the second patch includes this.
Comment 3 rabbitmq 2014-10-24 15:18:19 UTC
Comment, if required, to approve the maintainer address change to freebsd@
Comment 4 John Marino freebsd_committer 2014-11-01 12:48:25 UTC
1) I would recommend keeping freebsd@ for everything.  Otherwise bugzilla is going to get confused when you submit PRs under one email and it doesn't match the port maintainer email.  It will not understand you are the maintainer.

Also, it's fantastic that you poudriere tested it. You should upload the logs as an attachment when you do that.

I'll move this to patch-ready with the recommandation to take the second patch (the one that consolidates to freebsd@ email address)
Comment 5 Geoff Garside 2014-11-01 13:09:43 UTC
Yeah, that does sound like it would be best. I'll keep the uploading of the poudriere logs in mind next time.
Comment 6 commit-hook freebsd_committer 2014-11-07 19:33:22 UTC
A commit references this bug:

Author: pawel
Date: Fri Nov  7 19:32:35 UTC 2014
New revision: 372293
URL: https://svnweb.freebsd.org/changeset/ports/372293

Log:
  - Update to version 0.5.2 [1]
  - Convert to options helpers, trim long line

  PR:		194579 [1]
  Submitted by:	maintainer [1]

Changes:
  head/net/rabbitmq-c-devel/Makefile
  head/net/rabbitmq-c-devel/distinfo
  head/net/rabbitmq-c-devel/pkg-plist