Bug 194594 - New port: security/lastpass-cli: LastPass command line interface tool
Summary: New port: security/lastpass-cli: LastPass command line interface tool
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-25 12:50 UTC by Thomas Hurst
Modified: 2014-11-04 17:23 UTC (History)
1 user (show)

See Also:

Attachments
security/lastpass-cli shar (3.57 KB, text/plain)
2014-10-25 12:50 UTC, Thomas Hurst 		no flags Details
Updated shar for 2014-10-27 (3.90 KB, text/plain)
2014-10-28 00:20 UTC, Thomas Hurst 		no flags Details
Updated shar for 2014-10-31 (4.00 KB, text/plain)
2014-10-31 19:37 UTC, Thomas Hurst 		no flags Details
poudriere testport on FreeBSD 10.0 jail (29.96 KB, text/plain)
2014-11-01 10:06 UTC, Thomas Hurst 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hurst 2014-10-25 12:50:05 UTC 
Created attachment 148638 [details]
security/lastpass-cli shar

lastpass-cli is an open-source command-line interface to the popular LastPass
password management service.

WWW: https://github.com/lastpass/lastpass-cli
WWW: https://lastpass.com/
Comment 1 Thomas Hurst 2014-10-28 00:20:38 UTC 
Created attachment 148719 [details]
Updated shar for 2014-10-27

This is an updated shar, using a slightly newer version, which has some documentation improvements and better support for multiple accounts.

The port now has optional runtime dependencies on pinentry, xclip and xsel.

Tested with porttools and poudriere testport on RELENG_10.
Comment 2 Thomas Hurst 2014-10-29 12:54:35 UTC 
Further testing via Redports shows odd asciidoc/xmlto dependency errors on 8.4 and 9.2 (maybe just a Redports issue?), and a compiler error because the -Wno-language-extension-token flag is unav

Removing that leaves it with a linking error because the base version of OpenSSL is apparently too old to provide PKCS5_PBKDF2_HMAC().
Comment 3 Thomas Hurst 2014-10-31 19:37:32 UTC 
Created attachment 148833 [details]
Updated shar for 2014-10-31

This build has fallback code for OpenSSL <1.0.0 and builds successfully on 9.3, 10.0 and 10.1.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-11-01 08:12:56 UTC 
visually this looks good.  The only nit I have is OPTIONS_DEFINE normally comes immediately after OPTIONS_DEFAULT.

As the front page of redports says, it's basically useless now, especially for QA purposes.  It's untrustworthy and you shouldn't bother.

That said, do you have the ability (e.g. resources) to provide a poudriere test log with stage-qa checks performed (e.g. poudriere bulk with -t option or poudriere testport)?  If yes, and you attach it, I can move this to patch-ready without hesitation pending a good log.
Comment 5 Thomas Hurst 2014-11-01 10:06:50 UTC 
Created attachment 148862 [details]
poudriere testport on FreeBSD 10.0 jail

Thanks, testport log attached.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-01 10:30:20 UTC 
Thanks, promoting as promised!
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-11-04 17:11:44 UTC 
A commit references this bug:

Author: marino
Date: Tue Nov  4 17:11:06 UTC 2014
New revision: 372155
URL: https://svnweb.freebsd.org/changeset/ports/372155

Log:
  Add new port security/lastpass-cli

  PR:		194594
  Submitted by:	Thomas Hurst

  lastpass-cli is an open-source command-line interface to the popular
  LastPass password management service.

Changes:
  head/security/Makefile
  head/security/lastpass-cli/
  head/security/lastpass-cli/Makefile
  head/security/lastpass-cli/distinfo
  head/security/lastpass-cli/pkg-descr
  head/security/lastpass-cli/pkg-message
Comment 8 John Marino freebsd_committer freebsd_triage 2014-11-04 17:12:55 UTC 
I did some minor formatting tweaks and removed one of the WWW lines from pkg-descr (you can only have one).  Everything else was fine, thanks!
Comment 9 Thomas Hurst 2014-11-04 17:23:09 UTC 
Lovely, thank you :)