Created attachment 148669 [details]
Update of Piwigo 2.6.3 to 2.7.1.
This is a feature and bugfix update.
For full description, see release notes http://piwigo.org/releases/2.7.0 and http://piwigo.org/releases/2.7.1
Created attachment 148671 [details]
Missed the change from _WEB to _MOD
The patch is invalid. @dir is not a new name for @dirrm.
99% of the time, @dirrm* lines need to be removed, not modified. I think that's the case here. Please review the @dir entry in /usr/ports/CHANGES .
Created attachment 149153 [details]
piwigo 2.7.1 patch
I was also working on the piwigo port, so here's my patch. This one should have only the necessary @dir entries. I also cleaned up the Makefile a bit.
In my opinion copying the local directory to local.sample has become obsolete, since they would both contain the same files initially, but only completing the installation from within the piwigo UI will create a config.inc.php and database.inc.php. These will not be removed by a pkg delete, since those are created post-installation of the port.
Created attachment 149154 [details]
piwigo 2.7.1 build log
Ralf's patch looks good to me and it comes with a test log.
I will make the assumption that the maintainer will approve this improvement on his on submission and promote this PR to the patch-ready pool.
More than happy to approve. And if Ralf want's to take over maintainership, that would be great!
(In reply to John Marino from comment #5)
> Ralf's patch looks good to me and it comes with a test log.
> I will make the assumption that the maintainer will approve this improvement
> on his on submission and promote this PR to the patch-ready pool.
I'd be happy to take over maintainership.
(In reply to Ralf van der Enden from comment #7)
> I'd be happy to take over maintainership.
A commit references this bug:
Date: Thu Nov 13 14:08:46 UTC 2014
New revision: 372520
www/piwigo: update 2.6.3 -> 2.7.1
- Change maintainership to email@example.com (maintainer approved)
- Drop @dirrm usage from pkg-plist
Submitted by: Ralf van der Enden <firstname.lastname@example.org>
Approved by: mentors (implicit)
Committed with minor changes (mhash is no loger valid knob in USE_PHP), thanks for your work so far Goran, and Ralph, thanks a lot for volunteering!