Bug 194733 - sysutils/munin-node [WARNING] Service if_packets_re0 returned no data for label opackets
Summary: sysutils/munin-node [WARNING] Service if_packets_re0 returned no data for lab...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-01 09:02 UTC by Claudius Herder
Modified: 2014-11-17 21:45 UTC (History)
0 users

See Also:


Attachments
patch for patch-plugins__node.d.freebsd__if_packets_.in (1006 bytes, patch)
2014-11-01 09:02 UTC, Claudius Herder
no flags Details | Diff
patch-plugins__node.d.freebsd__if_packets_.in.patch (408 bytes, patch)
2014-11-17 21:19 UTC, Claudius Herder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Claudius Herder 2014-11-01 09:02:56 UTC
Created attachment 148851 [details]
patch for patch-plugins__node.d.freebsd__if_packets_.in

Plugin if_packets_ returns no data for physical links and tun interfaces.

2014/11/01 09:05:00 [WARNING] Service if_packets_tun0 on server.ambtec.de/localhost:4949 returned no data for label opackets
2014/11/01 09:05:00 [WARNING] Service if_packets_tun0 on server.ambtec.de/localhost:4949 returned no data for label rpackets
2014/11/01 09:05:15 [WARNING] Service if_packets_re0 on server.ambtec.de/localhost:4949 returned no data for label rpackets
2014/11/01 09:05:15 [WARNING] Service if_packets_re0 on server.ambtec.de/localhost:4949 returned no data for label opackets

Attached patch should fix the issue.

I'm unsure about the  if (NF == 10) case, maybe "rpackets.value", $4;  must be adjusted to "rpackets.value", $3;

I tested my modifications on FreeBSD 10.0.
Comment 1 John Marino freebsd_committer 2014-11-01 09:12:38 UTC
auto-assignment failed because title didn't fully specify port.  manually assigning to maintainer.
Comment 2 Mathieu Arnold freebsd_committer 2014-11-17 14:27:55 UTC
Hum, fun fact, there are 10 fields on freebsd < 8, 11 on 8 and 9, and 12 on 10+

Now, that's easy, but the fourth field can be empty if there is no mac address on the Interface (can happen for tunnels, loopback... So it's not that easy to fix, but thanks for pointing the packets bug, led me to this new issue :-)
Comment 3 commit-hook freebsd_committer 2014-11-17 15:04:40 UTC
A commit references this bug:

Author: mat
Date: Mon Nov 17 15:04:22 UTC 2014
New revision: 372671
URL: https://svnweb.freebsd.org/changeset/ports/372671

Log:
  - Fix bugs in if_* (prompted by [1])
  - Add a new PERL option to add some extra dependencies needed by some modules
    (based on [2])

  PR:		194733 [1] 195021 [2]
  Submitted by:	Claudius Herder [1]  John W. O'Brien [2]
  Sponsored by:	Absolight

Changes:
  head/sysutils/munin-node/Makefile
  head/sysutils/munin-node/files/patch-node__munin-node.conf.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_errcoll_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_packets_.in
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__iostat.in
  head/sysutils/munin-node/files/patch-plugins__node.d__hddtemp_smartctl.in
  head/sysutils/munin-node/files/patch-plugins__node.d__multiping.in
  head/sysutils/munin-node/files/patch-plugins__node.d__squeezebox_.in
  head/sysutils/munin-node/pkg-plist
Comment 4 Claudius Herder 2014-11-17 21:19:28 UTC
Created attachment 149532 [details]
patch-plugins__node.d.freebsd__if_packets_.in.patch

I still need attached patch, else I don't get any values from if_packets_
Comment 5 Mathieu Arnold freebsd_committer 2014-11-17 21:45:00 UTC
(In reply to claudius.herder from comment #4)
> Created attachment 149532 [details]
> patch-plugins__node.d.freebsd__if_packets_.in.patch
> 
> I still need attached patch, else I don't get any values from if_packets_

Damn, yes, thanks.
Comment 6 commit-hook freebsd_committer 2014-11-17 21:45:11 UTC
A commit references this bug:

Author: mat
Date: Mon Nov 17 21:45:01 UTC 2014
New revision: 372693
URL: https://svnweb.freebsd.org/changeset/ports/372693

Log:
  Actually make if_packets_ work.

  PR:		194733
  Submitted by:	Claudius Herder
  Sponsored by:	Absolight

Changes:
  head/sysutils/munin-node/Makefile
  head/sysutils/munin-node/files/patch-plugins__node.d.freebsd__if_packets_.in