Bug 194764 - ctladm always return 1
Summary: ctladm always return 1
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.0-RELEASE
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-02 18:02 UTC by Michael Rasmussen
Modified: 2017-01-07 21:39 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rasmussen 2014-11-02 18:02:45 UTC 
When invoking ctladm devlist the command will always have a return value of 1 whether the commands succeed or not.

The part responsible for this:
	retval = XML_Parse(parser, lun_str, strlen(lun_str), 1);
	XML_ParserFree(parser);
	if (retval != 1) {
		retval = 1;
		goto bailout;
	}

Should ctladm not return 0 (zero) in case of success?
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2017-01-07 21:39:52 UTC 
It has been fixed in the meantime, thanks for reporting