Bug 194792 - [amdtemp] [patch] all cpu support
Summary: [amdtemp] [patch] all cpu support
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 10.0-RELEASE
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-03 20:26 UTC by Ivan Rozhuk
Modified: 2018-03-03 11:54 UTC (History)
4 users (show)

See Also:


Attachments
patch (46.71 KB, patch)
2014-11-03 20:26 UTC, Ivan Rozhuk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2014-11-03 20:26:51 UTC
Created attachment 149000 [details]
patch

Completely rewritten amdtemp driver.
There is no longer binding to the processor ID, all the new processors will be supported without the need to modify the code.

Maybe for older CPUs (FAMILY 0x0f) that it would not work, I have not had a chance to test.

sensor_offset - can be customized for each sensor separately.
In fact there is only one sensor to the processor.

Thermtrip Status - all registers are read-only. 
Hardware Thermal Control (HTC) - everything except HtcTmpLmt available for recording. 
Reported Temperature Control - everything except CurTmp available for recording. 
SB-TSI - most writable. 
Register values ​​can be found in the documentation on the processor.
Comment 1 sasamotikomi 2015-02-19 19:22:36 UTC
(In reply to rozhuk.im from comment #0)
Can you sync you patch with current changes and add your code to review follow instruction:
https://wiki.freebsd.org/CodeReview
Comment 2 Ivan Rozhuk 2015-02-21 23:06:15 UTC
Synchronization is not required: the driver is written so that it does not need ID processors, he determines which interfaces are available for temperature reading.

I don't have @freebsd.org account, so it take a time.
Comment 3 Dan Langille freebsd_committer 2015-08-30 00:41:34 UTC
CPU temps is very good to have.