the new port x11-fm/librfm is not jobs safe (this affects both platforms). It also installs the .pc file in the wrong location for DragonFly. This is my fix for librfm: CONFIGURE_ARGS+= --with-pkglibdata MAKE_JOBS_UNSAFE= yes The CONFIGURE_ARGS line won't hurt FreeBSD and it fixes dragonFly. I think you should add both lines to the makefile. x11-fm/rodent also has issues. It won't fully build on DragonFly, but I did discover this is needed for systems without the perl symlink: USES+= shebangfix SHEBANG_FILES= configure Please add the equivalent on those lines the rodent makefile.
Maintainers CC'd
I'll take a look on it asap
committed thanks. Btw, I try to build the FBSD ports in DF without success, there is a manual to do that ?
A commit references this bug: Author: rodrigo Date: Sun Nov 16 21:56:24 UTC 2014 New revision: 372653 URL: https://svnweb.freebsd.org/changeset/ports/372653 Log: - fix x11-fm/librfm and rodent issues with DFbsd - fix librfm pkg-descr - remove unnecesary dirrm & dirrmtry PR: ports/194834 Submitted by: marino Approved by: mentors (implicit) Changes: head/x11-fm/librfm/Makefile head/x11-fm/librfm/pkg-descr head/x11-fm/librfm/pkg-plist head/x11-fm/rodent/Makefile head/x11-fm/rodent/pkg-plist
most would build if you stick it in /usr/ports but if checks arch (e.g. ONLY _FOR_ARCH= amd64 or ".if ${ARCH} == amd64") then it would fail because these are converted to x86_64. But basically it has to be placed in /usr/dports, that's the main trick.
by the way, rodent actually didn't build with this new version. unless you fixed this error: ../../plugins/mount_points/fstab-module.i:309:3: error: #error "This should not happen"
reopened to fix the bug reported by marino@
thanks. I was going to eventually look at it, but maybe the issue will be obvious (I haven't looked yet).
I got rodent building with this added to Makefile.DragonFly : post-patch: ${REINPLACE_CMD} -e 's|ac_uname_s=.*|ac_uname_s=FreeBSD|' \ ${WRKSRC}/apps/fgr/configure \ ${WRKSRC}/apps/rodent-pkg/configure \ ${WRKSRC}/apps/rodent-iconmgr/configure \ ${WRKSRC}/apps/rodent-fgr/configure \ ${WRKSRC}/apps/rodent-fm/configure \ ${WRKSRC}/apps/rodent-diff/configure The problem is ac_name_s only checks FreeBSD and OpenBSD to define "THIS_IS_BSD". I guess the configure scripts need to be fixed upstream.
Rodrigo, is there an update for this PR? What (if anything) do you want to do? Maybe file a bug upstream?
I"m running out of time at the moment but I'll take in count your remarks.
Rodrigo, why does rodent and librfm require the japanese version of gawk? gawk:${PORTSDIR}/japanese/gawk This port is so old that texinfo can't build its documentation anymore and I was going to just remove it from dports, but these dependencies are hindering that.
dependency fixed
I just opened a ticket at upstream to ask for a fix, in the meantime we cn consider something like what you suggest : sed 's%"\$ac_uname_s" = "FreeBSD"%"\$ac_uname_s" = "DragonFlyBSD" || "\$ac_uname_s" = "FreeBSD"%' I'm right now building the dports and if it it works to me :)
@marino, got your point about the fix for DF. I opened a ticket upstream to fix rodent for DF and they responded a fix is on the way. I think we can close this PR now.
great, thanks! go ahead and close it. I'll remove the DF patches from dports when the fix comes in.