Bug 194935 - pfctl(8) remove No ALTQ warning message
Summary: pfctl(8) remove No ALTQ warning message
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.0-RELEASE
Hardware: Any Any
: Normal Affects Many People
Assignee: George V. Neville-Neil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-10 21:47 UTC by lyndon
Modified: 2018-03-11 07:31 UTC (History)
3 users (show)

See Also:


Attachments
quiesce pfctl's diagnostic about ALTQ until -v is set. (439 bytes, patch)
2015-02-03 00:24 UTC, Jim Thompson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lyndon 2014-11-10 21:47:16 UTC
Generic kernels have no ALTQ support.  pfctl barks:

  No ALTQ support in kernel
  ALTQ related functions disabled

every time it is run when the kernel doesn't have ALTQ support.

This is useless noise. The default kernels are not compiled with ALTQ, and the majority of pf users don't use queues anyway.  pfctl already fails with an appropriate diagnostic when faced with an altq-related directive in the absence of ALTQ support, so why not move this diagnostic into that specific error scenario?

The current behavior just annoys: (a) those who don't care, (b) those who don't know about ALTQ, and (c) those who have to explain to (b) that their firewall has not suddenly been breached by hordes of hackers.

Can we please move this diagnostic out of the default code path and into a more appropriate location?
Comment 1 Jim Thompson 2015-02-03 00:24:08 UTC
Created attachment 152504 [details]
quiesce pfctl's diagnostic about ALTQ until -v is set.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-07-20 23:24:58 UTC
A commit references this bug:

Author: gnn
Date: Mon Jul 20 23:24:26 UTC 2015
New revision: 285730
URL: https://svnweb.freebsd.org/changeset/base/285730

Log:
  Only report the lack of ALTQ support if pfctl is using verbose (-v) mode.

  PR:		194935
  Submitted by:	Jim Thompson
  MFC after:	2 weeks

Changes:
  head/sbin/pfctl/pfctl.c
Comment 3 Adam McDougall 2015-11-21 22:42:01 UTC
Can this be merged into 10-stable?  Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-03-03 23:25:55 UTC
A commit references this bug:

Author: gnn
Date: Thu Mar  3 23:25:31 UTC 2016
New revision: 296370
URL: https://svnweb.freebsd.org/changeset/base/296370

Log:
  MFC 285730
  Only report the lack of ALTQ support if pfctl is using verbose (-v) mode.

  PR:		194935
  Submitted by:	Jim Thompson
  Approved by: re (gjb)

Changes:
_U  stable/10/
  stable/10/sbin/pfctl/pfctl.c
Comment 5 Adam McDougall 2017-11-27 02:44:10 UTC
I believe this can be closed?