Created attachment 149285 [details] shar archive of databases/gomdb [New port] Go wrapper for OpenLDAP Lightning Memory-Mapped Database (LMDB). WWW: https://github.com/szferi/gomdb WWW: http://symas.com/mdb/ Redport logs: https://redports.org/buildarchive/20141111143153-06536/
Created attachment 149286 [details] poudriere testport output
Created attachment 149287 [details] poudriere testport portlint output
X.if ${OSVERSION} >= 900033 && exists(/usr/bin/clang) XCC= clang XCXX= clang++ XGYP_DEFINES+= clang=1 X.else XUSE_GCC?= yes XGYP_DEFINES+= gcc_version=${CXX:S/g++//} X.endif This looks like can be converted to USES=compiler. XCONFIGURE_ENV+= CC=${CC} \ X CXX=${CXX} \ Is this really necessary? MAKE_ENV already have those.
ping - I had the exact same question to another [new port] PR cheffo submitted.
At the time I have tested which is like two months ago they were needed. Those ports were needed for building/porting influxdb (but now I'm waiting for version 0.9.0) and do not have time to experiment before upstream release update. Once influxdb 0.9* is released I'm going to update all dependencies and will check again.
Created attachment 153440 [details] gomdb shar file Let me know if this variant of the port is acceptable.
Created attachment 153441 [details] poudriere testport output
X.if ${COMPILER_TYPE} == clang XCC= clang X.else XUSE_GCC?= yes X.endif what are you trying to accomplish? What is the requirement for the compiler? I think you need to use "USES=compiler:<feature>" where you fill in the feature that you want. Do you need c++11? You are obviously trying to force gcc48 for FreeBSD 8 and 9, but you don't say why.
The only way to compile this port on FreeBSD with clang is to set CC=clang The port system do not se this properly (I have no idea why) but grep other ports and you will see that this is how people address this issue. If CC=clang is not set in the environment the build faild miserably with criptic error. So what is the right way to "guess" CC and set it for GO ENV and to get the port working with clang?
See https://github.com/szferi/gomdb : Build go get github.com/szferi/gomdb There is no dependency on LMDB dynamic library. On FreeBSD 10, you must explicitly set CC (otherwise it will fail with a cryptic error), for example: CC=clang go test -v As I said our go support is not great so I'm trying to workaround known issues. Let me know if there is another way to know if clang or gcc is used.
well, that software must be garbage. On later FreeBSD "cc" is a symlink to "clang"; they are the same thing. The fact that the software is relying on the name of the executable to determine that is not a good sign. Really, the fact that it's sensitive to which compiler is being uses is also not a good sign. Okay, so at least you have a valid reason for this. I need to you make 2 simple changes and we'll have to accept this as a workaround. 1) change "USE_GCC?= yes" to "USE_GCC=yes" 2) above ".if ${COMPILER_TYPE} == clang" add a block of comments explaining that the value of "CC" must be "clang" (checked by configure) otherwise the build fails on FreeBSD10+
Created attachment 153792 [details] updated shar file as requested.
Still needs a tweak. If I am readying shar correctly, you have two WWW: lines on pkg-descr file. You are limited to one.
I copied this approach from other port like ports/www/npm/pkg-descr but I'll fix and resend tomorrow.
okay. I guess the npm reviewer missed it.
A commit references this bug: Author: pi Date: Wed Oct 14 05:44:50 UTC 2015 New revision: 399239 URL: https://svnweb.freebsd.org/changeset/ports/399239 Log: New port: databases/gomdb Go wrapper for OpenLDAP Lightning Memory-Mapped Database, LMDB. WWW: https://github.com/szferi/gomdb PR: 194946 Submitted by: cheffo@freebsd-bg.org Changes: head/databases/Makefile head/databases/gomdb/ head/databases/gomdb/Makefile head/databases/gomdb/distinfo head/databases/gomdb/pkg-descr head/databases/gomdb/pkg-plist
Test-builds on 11a, 10.2a+i, 9.3 are fine. Committed, thanks!