Bug 194958 - x11/nvidia-driver-304 broken for some time on 10, and 11
Summary: x11/nvidia-driver-304 broken for some time on 10, and 11
Status: Closed DUPLICATE of bug 194866
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-12 05:11 UTC by Chris Hutchinson
Modified: 2014-11-15 16:53 UTC (History)
0 users

See Also:
portmaster: maintainer-feedback? (danfe)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2014-11-12 05:11:51 UTC
x11/nvidia-driver-304 has not been buildable for about a month,
on 10, and 11-CURRENT.
This is the output generated from the failure:

-aes -mno-avx -Qunused-arguments -c nvidia_os.c
--- nvidia_linux.o ---
nvidia_linux.c:45:30: error: redefinition of 'rights'
    u_long cmd; cap_rights_t rights;
                             ^
nvidia_linux.c:43:18: note: previous definition is here
    cap_rights_t rights;
                 ^
1 error generated.
*** [nvidia_linux.o] Error code 1

make[3]: stopped in /usr/ports/x11/nvidia-driver-304/work/NVIDIA-FreeBSD-x86_64-
304.123/src
1 error

make[3]: stopped in /usr/ports/x11/nvidia-driver-304/work/NVIDIA-FreeBSD-x86_64-
304.123/src
*** [_sub.all] Error code 2

make[2]: stopped in /usr/ports/x11/nvidia-driver-304/work/NVIDIA-FreeBSD-x86_64-
304.123
1 error

make[2]: stopped in /usr/ports/x11/nvidia-driver-304/work/NVIDIA-FreeBSD-x86_64-
304.123
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/x11/nvidia-driver-304
*** Error code 1

Stop.
make: stopped in /usr/ports/x11/nvidia-driver-304


There is no package, which makes it impossible for those that
have nVidia cards to use X, on recent versions of FreeBSD.
What must be donr to fix this?

Thank you for all your time, and consideration.

--Chris
Comment 1 Bugzilla Automation freebsd_committer 2014-11-12 05:11:51 UTC
Auto-assigned to maintainer danfe@FreeBSD.org
Comment 2 commit-hook freebsd_committer 2014-11-15 16:46:11 UTC
A commit references this bug:

Author: danfe
Date: Sat Nov 15 16:45:11 UTC 2014
New revision: 372606
URL: https://svnweb.freebsd.org/changeset/ports/372606

Log:
  - Stop trying to adopt cap_rights_t type change in FreeBSD src SVN r255219
    as recent driver versions are already account for it; this unbreaks the
    build for 304.xx branch [*]
  - Simplify patching for stack buffer overflow in nvidia_sysctl_bus_type():
    NVidia really screwed up fixing it since it was reported.  Originally,
    they were sprintf(bus_type, "PCI-E")ing to a 4-character buffer allocated
    on stack (304.88 and earlier); later they've replaced the buffer with a
    char * pointer, but left one sprintf() into it (304.108 and above, up to
    304.121); then finally fixed it for real in 304.123.  Given versions are
    only for 304.xx branch; others retained the same bugs during this time
    frame.  Fix it across the gang by simply extending bus_type[4] (if found)
    to eight bytes instead of employing complex NVVERSION checks: this should
    now be no-op for newer versions, but good enough for older ones (e.g. for
    173.14.35, 96.xx, and 71.xx)

  PR:	194866, 194958 [*]

Changes:
  head/x11/nvidia-driver/Makefile
Comment 3 Alexey Dokuchaev freebsd_committer 2014-11-15 16:53:45 UTC
Should be fixed in ports r372606 (however, closing it as duplicate of 194866 as technically it is).

*** This bug has been marked as a duplicate of bug 194866 ***