Bug 195219 - [maintainer] textproc/ibus build error
Summary: [maintainer] textproc/ibus build error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2014-11-20 12:13 UTC by martin.dieringer
Modified: 2015-02-08 18:49 UTC (History)
4 users (show)

See Also:
martin.dieringer: maintainer-feedback? (henry.hu.sh)


Attachments
update ibus to 1.5.9 (4.38 KB, patch)
2014-11-25 00:03 UTC, Henry Hu
no flags Details | Diff
2nd ver (4.16 KB, patch)
2015-02-07 04:06 UTC, Henry Hu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description martin.dieringer 2014-11-20 12:13:44 UTC
it misses the directory /usr/local/etc/dconf/db

workaround: 'mkdir -p /usr/local/etc/dconf/db' before building
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-20 12:13:44 UTC
Maintainer CC'd
Comment 2 Henry Hu 2014-11-21 04:37:27 UTC
I just tried to build ibus. I confirmed that /usr/local/etc/dconf/db and /usr/local/etc/dconf/profile do not exist before building the port.
It was built and installed successfully.
Would you please show me more logs about the problem?
Comment 3 martin.dieringer 2014-11-21 09:30:10 UTC
# cd /usr/ports/textproc/ibus ; make

... [in stage]

 install  -o root -g wheel -m 0644 profile/ibus '/ports/textproc/ibus/work/stage/usr/local/etc/dconf/profile'
 /bin/mkdir -p '/ports/textproc/ibus/work/stage/usr/local/share/GConf/gsettings'
 install  -o root -g wheel -m 0644 ibus.convert '/ports/textproc/ibus/work/stage/usr/local/share/GConf/gsettings'
if test -n "org.freedesktop.ibus.gschema.xml"; then \
        test -z "/usr/local/share/glib-2.0/schemas" || /bin/mkdir -p "/ports/textproc/ibus/work/stage/usr/local/share/glib-2.0/schemas"; \
        install  -o root -g wheel -m 0644 org.freedesktop.ibus.gschema.xml "/ports/textproc/ibus/work/stage/usr/local/share/glib-2.0/schemas"; \
        test -n "/ports/textproc/ibus/work/stage" || glib-compile-schemas /usr/local/share/glib-2.0/schemas; \
fi
gmake  install-data-hook
gmake[7]: Entering directory '/ports/textproc/ibus/work/ibus-1.5.5/data/dconf'
dconf update
error: Error opening directory '/usr/local/etc/dconf/db': No such file or directory

# pkg info dconf
dconf-0.22.0
...
Comment 4 Henry Hu 2014-11-21 22:10:28 UTC
ok, this seems to be a problem caused by new dconf, and I tried with the dconf from pkg which is an old one.
It seems like that ibus has fixed this:
https://github.com/ibus/ibus/commit/e6ec45d64a32d16245770f8b80e795a63e6ad553

By the way, ibus has released 1.5.9 while we still have ibus 1.5.5. They moved from goglecode to github.
I'll create an update for ibus which would solve this problem, and maybe others as well.
Comment 5 Henry Hu 2014-11-24 23:58:29 UTC
I've created a patch for ibus 1.5.9.
It builds and runs, and it passed some simple testing.
But I'm not sure if it's ok, because redports is down and I don't have a clean environment to test it.
Would you please test the attached patch?
Comment 6 Henry Hu 2014-11-25 00:03:10 UTC
Created attachment 149809 [details]
update ibus to 1.5.9

Experimental patch to update ibus to 1.5.9. The bug reported is fixed in the new version of ibus.
Comment 7 John Marino freebsd_committer freebsd_triage 2015-01-25 18:13:13 UTC
I've added "[maintainer]" to subject to show maintainer has provided a patch. However, this is a version upgrade and there's no log proving this passes stage-qa.  Can a poudriere log be added to move this PR along?
Comment 8 Henry Hu 2015-01-25 18:21:32 UTC
> make stage-qa
====> Running Q/A tests (stage-qa)
> make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

Since redports is down, I have no way to perform better tests other than building & installing & running check-plist.
Is it required for every port maintainer to run a poudriere? Is there any facilities for maintainers to test new versions?
Comment 9 John Marino freebsd_committer freebsd_triage 2015-01-25 18:50:08 UTC
(In reply to Henry Hu from comment #8)

I'll accept that output and promote the PR.

> Since redports is down, I have no way to perform better tests other
> than building & installing & running check-plist.

fyi, redports is considered less than useless at this point, so even if it were functioning, "passing redports" doesn't mean anything.  Hopefully an upgrade will fix redports, I have no ETA on that.

Is it required for every port maintainer to run a poudriere? 

officially, no.
If you want me to promote, then pretty much yes.
Other reviewers are less stringent.
If you want to get your PRs cherry-picked, submit test logs without asking.  Those get promoted first.

Is there any facilities for maintainers to test new versions?

local poudriere is best right now.
Your check-plist / stage-qa output is mildly acceptable but it doesn't test everything and can be contaminated by live system.
Comment 10 Dmitry Marakasov freebsd_committer freebsd_triage 2015-01-26 17:42:40 UTC
Shouldn't you depend on glib20 and librsvg through USE_GNOME=glib20 and USE_GNOME=librsvg2?
Comment 11 Henry Hu 2015-01-27 01:31:11 UTC
(In reply to Dmitry Marakasov from comment #10)
For librsvg2: ok, I'll change it.
For glib20: can we specify ">=2.32" with USE_GNOME?
Comment 12 John Marino freebsd_committer freebsd_triage 2015-02-06 10:51:16 UTC
"For glib20: can we specify ">=2.32" with USE_GNOME?"

Why do you need to?  it's been true in the ports tree since march 2013.  I can't imagine there are any versions of glib20 older than this with a current ports tree.
Comment 13 John Marino freebsd_committer freebsd_triage 2015-02-06 10:52:22 UTC
besides, the mk files will take care of the version requirements.
Comment 14 Henry Hu 2015-02-07 04:06:23 UTC
Created attachment 152657 [details]
2nd ver

2nd version of the patch

add glib20 and librsvg2 to USE_GNOME
Comment 15 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-08 10:13:02 UTC
Testing @work.
Comment 16 commit-hook freebsd_committer freebsd_triage 2015-02-08 18:48:24 UTC
A commit references this bug:

Author: pi
Date: Sun Feb  8 18:48:06 UTC 2015
New revision: 378669
URL: https://svnweb.freebsd.org/changeset/ports/378669

Log:
  textproc/ibus: 1.5.5 -> 1.5.9

  For changes see
  https://github.com/ibus/ibus/commits/master

  This also fixes the build problem reported by martin.dieringer@gmx.de.

  PR:		195219
  Submitted by:	Henry Hu <henry.hu.sh@gmail.com> (maintainer)

Changes:
  head/textproc/ibus/Makefile
  head/textproc/ibus/distinfo
  head/textproc/ibus/pkg-plist
Comment 17 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-08 18:49:08 UTC
Build-tested, looks fine. Committed, thanks.