Created attachment 149667 [details]
Make lshell/checkconfig.py send syslog data to /var/run/log instead of non-existent /dev/log
shells/lshell doesn't log anything to syslog
lshell can log either to a file or to syslog depending on its configuration file.
Sadly, lshell tries to log through /dev/log which hasn't existed on FreeBSD for a long while.
Creating a symbolic link /dev/log -> /var/run/log didn't seem to fix the problem.
How to reproduce:
Install vanilla shells/lshell
Instruct it to log to syslog in /usr/local/etc/lshell.conf
'logfilename : syslog'
Rehash terminal, invoke lshell
Type commands, nope, syslog gets nothing
How to fix:
0.9.15.1 : Edit line 929 of lshellmodule/lshell.py to correctly point to /var/run/log
0.9.16 : Edit line 310 of lshell/checkconfig.py to correctly point to /var/run/log
Patch against 0.9.16 attached
Created attachment 149668 [details]
Patch for 0.9.15.1
Only for 0.9.15.1 , the other attachment is for 0.9.16
This port has no maintainer, patch looks straightforward and PR description is excellent. Promote to patch-ready status.
I didn't follow why there is a patch for version that was replaced in August 2014 (0.9.15.1). What was the point of providing that? FWIW, I grabbed this one first so it caused confusion when it didn't apply (it was named Patch-*, I was looking for the patch, easy mistake to make)
A commit references this bug:
Date: Fri Feb 6 10:07:21 UTC 2015
New revision: 378519
shells/lshell: fix syslog file location (/dev/log => /var/run/log)
Submitted by: dam (my.gd)
Approved by: n/a (unmaintained)
(In reply to John Marino from comment #3)
I should have clarified, sorry about the confusion.
I've provided a patch for 0.9.15.1 because we are not using 0.9.16 here.
0.9.16 causes a problem on *all* the boxes we've tried running it on, where certain commands (like ls) make the lshell process go in the background, at which point we can either kill it, or bring it back up with fg.
I'm gonna have to file a PR for that one.
but 0.9.15.1 is not in ports so there is nothing to patch.
Apparently you are maintaining it locally or just never updated.
Yup, we're keeping it locked so as to retain 0.9.15.1 which still works for us.
I really need to look into the backgrounding problem with 0.9.16 at some point and see if I can come up with a patch.
Once again my apologies for the confusion, will be more careful on my next PR.