Bug 195268 - [patch] archivers/ruby-lha: fix build for ruby 2.0
Summary: [patch] archivers/ruby-lha: fix build for ruby 2.0
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: freebsd-ruby (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-22 00:01 UTC by Lawrence Chen
Modified: 2015-04-14 15:12 UTC (History)
1 user (show)

See Also:
beastie: maintainer-feedback? (ruby)

Attachments
patch to build archivers/ruby-lha for ruby 2.0 (or ruby 2.1) (2.77 KB, patch)
2014-11-22 00:01 UTC, Lawrence Chen 		no flags Details | Diff
poudriere testport log for ruby 2.0 (12.59 KB, text/plain)
2014-11-22 00:01 UTC, Lawrence Chen 		no flags Details
poudriere testport log for ruby 2.1 (13.42 KB, text/plain)
2014-11-22 00:02 UTC, Lawrence Chen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2014-11-22 00:01:09 UTC 
Created attachment 149702 [details]
patch to build archivers/ruby-lha for ruby 2.0 (or ruby 2.1)

Have a backlog of things I've been patching to switch my systems to use a private repo using poudriere.

Among them was a patch to get archivers/ruby-lha to build for ruby 2.0.  The patch is based on upstream work on this issue.

Between the time I first made the patch and today, I see that the port has been updated to show that it doesn't build with ruby 2.1 either.

After some adjustments, I also tested this patch with ruby 2.1.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-22 00:01:09 UTC 
Auto-assigned to maintainer ruby@FreeBSD.org
Comment 2 Lawrence Chen 2014-11-22 00:01:58 UTC 
Created attachment 149703 [details]
poudriere testport log for ruby 2.0
Comment 3 Lawrence Chen 2014-11-22 00:02:37 UTC 
Created attachment 149704 [details]
poudriere testport log for ruby 2.1
Comment 4 Lawrence Chen 2015-03-29 12:15:17 UTC 
Why did this port get deprecated on March 1st, 2015, and then get unbroke on March 23rd, 2015 where 

my files/patch-ext-slide.c and files/patch-math-remainder are similar

and

my files/patch-ext-lhalib.c is a subset of files/patch-warnings

???
Comment 5 Steve Wills freebsd_committer freebsd_triage 2015-04-14 15:12:42 UTC 
(In reply to Lawrence Chen from comment #4)

Sorry, I can't comment on why the changes were made except what is shown in the commit messages. I can only guess maybe the committer wasn't aware of this PR. 

Sorry for the confusion, the port does seem to be working now.

I'll go ahead and close this as I don't think there's anything else to do. Please feel free to reopen and let me know if I'm mistaken.