Bug 195284 - audio/rawrec fails on 10.1 with sigaction report
Summary: audio/rawrec fails on 10.1 with sigaction report
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-22 16:48 UTC by antonfb
Modified: 2014-12-08 06:22 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description antonfb 2014-11-22 16:48:37 UTC
audio/rawrec port fails on 10.1 with error:

atlas.hesiod.org:anton[42]: rawrec
(null): sigaction on SIGIO failed: Invalid argument

Turns out sa_flags is not set in one case.  Earlier patches fixed that in other places.

Diff to fix

--- main.c.jaorg        2014-11-21 18:17:01.430856801 -0800
+++ main.c      2014-11-21 18:17:38.300047904 -0800
@@ -124,6 +124,7 @@
   strncpy(cnst_dflt_format, "s16_le", (size_t) (MAX_FORMAT_STRING_LENGTH + 1));
 
   /* at the moment, this application goes with the default for most signals */
+  ignorer_act.sa_flags = 0;
   ignorer_act.sa_handler = SIG_IGN;
   /* because I'm unclear on how SIGIO is supposed to work, it's not 
      applicable here, and I'm paranoid */
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-12-07 19:26:23 UTC
A commit references this bug:

Author: riggs
Date: Sun Dec  7 19:25:53 UTC 2014
New revision: 374223
URL: https://svnweb.freebsd.org/changeset/ports/374223

Log:
  Fix signal handling (runtime exit with invalid argument) on 10.1
  - Add missing sa_flags in main.c
  - Bump PORTREVISION

  While on it:
  - Add LICENSE*

  PR:		195284
  Submitted by:	antonfb@hesiod.org
  MFH:		2014Q4

Changes:
  head/audio/rawrec/Makefile
  head/audio/rawrec/files/patch-main.c
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2014-12-07 19:26:40 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-12-08 06:22:09 UTC
A commit references this bug:

Author: riggs
Date: Mon Dec  8 06:21:14 UTC 2014
New revision: 374233
URL: https://svnweb.freebsd.org/changeset/ports/374233

Log:
  MFH: r374223

  Fix signal handling (runtime exit with invalid argument) on 10.1
  - Add missing sa_flags in main.c
  - Bump PORTREVISION

  While on it:
  - Add LICENSE*

  PR:		195284
  Submitted by:	antonfb@hesiod.org
  Approved by:	ports-secteam (delphij)

Changes:
_U  branches/2014Q4/
  branches/2014Q4/audio/rawrec/Makefile
  branches/2014Q4/audio/rawrec/files/patch-main.c