Bug 195416 - www/linux-*-flashplugin11: disable ALSA after all and convert to an option
Summary: www/linux-*-flashplugin11: disable ALSA after all and convert to an option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch, regression
Depends on: 195788
Blocks: 192541
  Show dependency treegraph
 
Reported: 2014-11-26 15:49 UTC by Jan Beich
Modified: 2014-12-07 21:51 UTC (History)
1 user (show)

See Also:


Attachments
optionalize (7.76 KB, patch)
2014-11-26 15:49 UTC, Jan Beich
no flags Details | Diff
optionalize, v1.1 (7.72 KB, patch)
2014-11-26 16:25 UTC, Jan Beich
no flags Details | Diff
www/linux-c6-flashplugin11 log (26.76 KB, text/plain)
2014-11-26 16:31 UTC, Jan Beich
no flags Details
www/linux-f10-flashplugin11 log (26.98 KB, text/plain)
2014-11-26 16:32 UTC, Jan Beich
no flags Details
optionalize, v2 (8.55 KB, patch)
2014-11-26 18:58 UTC, Jan Beich
no flags Details | Diff
www/linux-c6-flashplugin11 log (26.51 KB, text/plain)
2014-11-26 18:59 UTC, Jan Beich
no flags Details
www/linux-f10-flashplugin11 log (26.72 KB, text/plain)
2014-11-26 18:59 UTC, Jan Beich
no flags Details
www/linux-c6-flashplugin11 log with ALSA=on (27.12 KB, text/plain)
2014-11-26 19:11 UTC, Jan Beich
no flags Details
www/linux-f10-flashplugin11 log with ALSA=on (28.00 KB, text/plain)
2014-11-26 19:12 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2014-11-26 15:49:32 UTC
Created attachment 149891 [details]
optionalize

ALSA output in Flash is fragile and doesn't work without major linuxulator update currently baking in dchagin's lemul branch. Backing out ports r373426 seems like a waste given that lemul is the future. Let's convert to an option, disabled by default and annotate (in _DESC) when to reconsider.

Reported by: Andrei <az@azsupport.com>
Comment 1 Jan Beich freebsd_committer 2014-11-26 16:25:45 UTC
Created attachment 149893 [details]
optionalize, v1.1

- unbreak f10
- backport MASTER_SITES nit from bug 192541 comment 4
Comment 2 Jan Beich freebsd_committer 2014-11-26 16:31:43 UTC
Created attachment 149894 [details]
www/linux-c6-flashplugin11 log
Comment 3 Jan Beich freebsd_committer 2014-11-26 16:32:28 UTC
Created attachment 149895 [details]
www/linux-f10-flashplugin11 log
Comment 4 John Marino freebsd_committer 2014-11-26 16:44:34 UTC
should I be concerned about these lines in the logs?

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: @dir %%LINUXBASE%%/usr/lib
Error: Orphaned: @dir %%LINUXBASE%%/usr
Error: Orphaned: @dir %%LINUXBASE%%
Error: Orphaned: @dir /compat
Comment 5 Jan Beich freebsd_committer 2014-11-26 17:01:21 UTC
Ironically, PepperFlash wrapped with freshplayerplugin has no such ALSA issue with current linuxulator.

(In reply to John Marino from comment #4)
> ===> Checking for items in STAGEDIR missing from pkg-plist
> Error: Orphaned: @dir %%LINUXBASE%%/usr/lib
> Error: Orphaned: @dir %%LINUXBASE%%/usr
> Error: Orphaned: @dir %%LINUXBASE%%
> Error: Orphaned: @dir /compat

They were present before. Probably an artifact from *not* using USE_LINUX_PREFIX while installing some files there.
Comment 6 John Marino freebsd_committer 2014-11-26 17:06:00 UTC
hmm, aren't they just empty directories in stage directory?
It's not worth removing them with post-install command?
Comment 7 Jan Beich freebsd_committer 2014-11-26 18:58:19 UTC
Created attachment 149900 [details]
optionalize, v2

(In reply to John Marino from comment #6)
> hmm, aren't they just empty directories in stage directory?
> It's not worth removing them with post-install command?

That's a regression from bug 192541. I forgot to alter ${MKDIR} line. With return of libflashsupport.so we need ${STAGEDIR}${LINUXBASE}/usr/lib again.

To fix ALSA=off there's probably no better way than @dir. It should have been implemented as a recursive keyword to mimic behavior under PREFIX. And even then |@dir /compat| would break if LINUXBASE is under anything other than /compat.
Comment 8 Jan Beich freebsd_committer 2014-11-26 18:59:02 UTC
Created attachment 149901 [details]
www/linux-c6-flashplugin11 log
Comment 9 Jan Beich freebsd_committer 2014-11-26 18:59:23 UTC
Created attachment 149902 [details]
www/linux-f10-flashplugin11 log
Comment 10 Jan Beich freebsd_committer 2014-11-26 19:11:49 UTC
Created attachment 149906 [details]
www/linux-c6-flashplugin11 log with ALSA=on
Comment 11 Jan Beich freebsd_committer 2014-11-26 19:12:43 UTC
Created attachment 149907 [details]
www/linux-f10-flashplugin11 log with ALSA=on
Comment 12 commit-hook freebsd_committer 2014-11-26 19:48:59 UTC
A commit references this bug:

Author: marino
Date: Wed Nov 26 19:48:26 UTC 2014
New revision: 373458
URL: https://svnweb.freebsd.org/changeset/ports/373458

Log:
  www/linux-*-flashplugin11: convert ALSA to option, but off by default

  ALSA output in Flash is fragile and doesn't work without the major
  linulator update currently baking in dchagin's lemul branch.   While
  waiting for that change, current ALSA to a disabled-by-default option.

  PR:		195416
  Submitted by:	Jan Beich
  Approved by:	Continuation of recent work

Changes:
  head/www/linux-c6-flashplugin11/Makefile
  head/www/linux-c6-flashplugin11/distinfo
  head/www/linux-c6-flashplugin11/pkg-plist
  head/www/linux-f10-flashplugin11/Makefile
  head/www/linux-f10-flashplugin11/distinfo
  head/www/linux-f10-flashplugin11/pkg-plist
Comment 13 John Marino freebsd_committer 2014-11-26 19:53:05 UTC
Let's hope everything is working now!