Bug 195531 - net/asio: update to the latest version
Summary: net/asio: update to the latest version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-30 17:42 UTC by Mikhail T.
Modified: 2014-12-04 22:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments
Update net/asio to 1.10.4 (16.55 KB, patch)
2014-11-30 17:42 UTC, Mikhail T.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2014-11-30 17:42:22 UTC
Created attachment 150035 [details]
Update net/asio to 1.10.4

The latest version available from upstream is 1.10.4, released on October 1st, 2014.

The port currently is still installing 1.4.8 -- which was released in February 2011, nearly 4 years ago.

Although the upstream's code compiles quite a few binaries (under examples/ and tests/) during install, it does NOT INSTALL them. It is therefor quite wasteful to require boost as well as to compile anything.

This update disables these needless compilations.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-30 17:42:22 UTC
Auto-assigned to maintainer acm@FreeBSD.org
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-02 20:22:36 UTC
Take, as acm@ is currently inactive.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-02 20:36:55 UTC
Removing boost dependency is totally incorrect: asio includes reference boost so at least run-dependency is needed. I'm also against dropping build step, as it proves that the library is usable. Without it, it asio code fails to compile, we won't know of it unless some consumer fail.
Comment 4 Mikhail T. 2014-12-04 14:03:27 UTC
Removing boost-dependency is quite correct. Header-files -- and that's all the port is installing -- are pure data. They don't depend on anything at all.

Likewise, ensuring, the headers are usable, would've made sense only if we were installing any binaries. Maybe, some of the examples bundled with the port could be usable to someone, but we never installed anything the port compiled -- and nobody has bothered to ask for it.

As things stand, we copy the upstream's data under PREFIX and there is no need to pretend, the port is doing anything else.

If the port-maintainer is going to be unreachable for a while, I'll just commit the changes myself...
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-04 15:12:20 UTC
> Removing boost-dependency is quite correct. Header-files -- and that's all the port is installing -- are pure data. They don't depend on anything at all.

They do. They refer to boost and are not usable without it. This is called runtime dependency.

> ensuring, the headers are usable, would've made sense only if we were installing any binaries.

This is complete nonsense.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-12-04 22:02:47 UTC
A commit references this bug:

Author: mi
Date: Thu Dec  4 22:01:52 UTC 2014
New revision: 373985
URL: https://svnweb.freebsd.org/changeset/ports/373985

Log:
  Upgrade from 1.4.8 to 1.10.4. Stop compiling things (tests, examples),
  which we aren't going to use or install.

  Instead of LIB-depending on boost, include RUN-dependency on one
  of boost's header-files. Because we are no longer compiling, we
  don't need boost installed at package-building time.

  PR:		195531
  Approved by:	maintainer timeout (see PR)

Changes:
  head/net/asio/Makefile
  head/net/asio/distinfo
  head/net/asio/files/patch-configure
  head/net/asio/files/patch-include__asio__impl__error_code.ipp
  head/net/asio/pkg-plist
Comment 7 Mikhail T. 2014-12-04 22:05:56 UTC
(In reply to Dmitry Marakasov from comment #5)
> This is complete nonsense.

I really don't care for such abuse. Please, refrain from contacting me again, Dmitry.