Bug 195665 - Fix www/squid build with clang 3.5.0
Summary: Fix www/squid build with clang 3.5.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Antoine Brodin
URL:
Keywords:
Depends on:
Blocks: 195480
  Show dependency treegraph
 
Reported: 2014-12-04 01:35 UTC by Dimitry Andric
Modified: 2014-12-05 14:26 UTC (History)
1 user (show)

See Also:


Attachments
Fix www/squid build with clang 3.5.0 (566 bytes, patch)
2014-12-04 01:35 UTC, Bugzilla Automation
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer 2014-12-04 01:35:35 UTC
Created attachment 150166 [details]
Fix www/squid build with clang 3.5.0

In bug 195480, I asked for an exp-run with clang 3.5.0.  One of the failures from that exp-run is in www/squid, which fails with many -Werror warnings.

Obviously the warnings should be fixed, but that requires too much churn, so the least painful solution is to simply squelch the warnings.

This patch also uses COMPILER_TYPE and COMPILER_VERSION from the ports framework, instead of hand-rolling a test for clang.
Comment 1 Antoine Brodin freebsd_committer 2014-12-05 13:14:20 UTC
I will work on this
Comment 2 commit-hook freebsd_committer 2014-12-05 14:25:05 UTC
A commit references this bug:

Author: antoine
Date: Fri Dec  5 14:24:38 UTC 2014
New revision: 374030
URL: https://svnweb.freebsd.org/changeset/ports/374030

Log:
  Allow building with clang 3.5
  Those warnings should be fixed, but squelch them for now

  PR:		ports/195665

Changes:
  head/www/squid/Makefile
Comment 3 Antoine Brodin freebsd_committer 2014-12-05 14:26:31 UTC
A different version of the patch has been committed, thanks