Created attachment 150238 [details] SHAR Hello, Please have a look at adding port for GCViewer tool. This little tool visualizes Java garbage collector logs providing performance metrics like throughput, timings of gc pauses, speed of collections. So it's widely used for performance analysis/monitoring of Java applications. This port makes java source code compilation instead of binary downloads. I'll checked build/installation steps, validated port by portlint & porttools. Also of course I've checked that it works functionally. :)
Created attachment 150239 [details] Port test logs
Few ideas for improvement: - port tries to fetch files during build phase, this is forbidden: http://people.freebsd.org/~pawel/buildlogs/GCViewer-1.34-10amd64.log - lines in Makefile should be broken around 80 characters for easier reading XPORTNAME= GCViewer Please don't use capital letters in port names. X#!/bin/sh X# X# $FreeBSD$ X XJAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -jar "%%JAVAJARDIR%%/gcviewer.jar" "$@" Use exec, please see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-sh-exec.html
I have ported several java-based ports that fetch during their build phase, and not only is this a bad idea, but it also make the build a moving target. So much, that it isn't a predictable and repeatable process. The best way to tackle this is to build locally, and then package up the repository that is populated by maven. Then point ant, or whatever compiler is used, to include your local build repository for sources. A good example of this is archivers/snappy-java Please let me know if you need any assistance, and I can see what I can help with. -jgh
No updated submission has been received more than 5 months after the initial review, so I'm closing the PR.