Bug 195740 - ports-mgmt/portshaker: Support Subversion 1.7 or 1.8 depending on make.conf
Summary: ports-mgmt/portshaker: Support Subversion 1.7 or 1.8 depending on make.conf
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-06 13:17 UTC by Simon Wright
Modified: 2014-12-27 14:57 UTC (History)
1 user (show)

See Also:


Attachments
Patch to make portshaker aware of WITH_SUBVERSION_VER (732 bytes, patch)
2014-12-06 13:17 UTC, Simon Wright
no flags Details | Diff
Poudriere build log (10.50 KB, text/plain)
2014-12-06 15:21 UTC, Simon Wright
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Wright 2014-12-06 13:17:52 UTC
Created attachment 150263 [details]
Patch to make portshaker aware of WITH_SUBVERSION_VER

Currently building portshaker package on a clean system will install subversion 1.8 even if 1.7 is defined in make.conf with WITH_SUBVERSION_VER=17.

Patch fixes this and will use either 1.7 or 1.8 as required for the run dependency.

Thanks to Olli Hauer for fixing the original issue (in ports-mgmt/portdowngrade).
Comment 1 Bugzilla Automation freebsd_committer 2014-12-06 13:17:52 UTC
Auto-assigned to maintainer romain@FreeBSD.org
Comment 2 Simon Wright 2014-12-06 15:21:11 UTC
Created attachment 150267 [details]
Poudriere build log
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-27 11:34:49 UTC
Maintainer timeout (3 weeks)
Comment 4 commit-hook freebsd_committer 2014-12-27 14:57:03 UTC
A commit references this bug:

Author: pi
Date: Sat Dec 27 14:56:33 UTC 2014
New revision: 375684
URL: https://svnweb.freebsd.org/changeset/ports/375684

Log:
  ports-mgmt/portshaker: Support Subversion 1.7 or 1.8 depending on make.conf

  Currently building portshaker package on a clean system will install
  subversion 1.8 even if 1.7 is defined in make.conf with
  WITH_SUBVERSION_VER=17.

  Patch fixes this and will use either 1.7 or 1.8 as required for the
  run dependency.

  PR:		195740
  Submitted by:	simon.wright@gmx.net
  Approved by:	romain (maintainer timeout)

Changes:
  head/ports-mgmt/portshaker/Makefile
Comment 5 Kurt Jaeger freebsd_committer 2014-12-27 14:57:34 UTC
Committed, thanks.