Bug 195821 - [exp-run] Force linking of `libperl.so` with all shared modules.
Summary: [exp-run] Force linking of `libperl.so` with all shared modules.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-09 12:05 UTC by Mathieu Arnold
Modified: 2014-12-17 13:27 UTC (History)
1 user (show)

See Also:
mat: exp-run?


Attachments
libperl.so.diff (11.30 KB, patch)
2014-12-09 12:05 UTC, Mathieu Arnold
no flags Details | Diff
libperl.so.diff (13.63 KB, patch)
2014-12-09 16:03 UTC, Mathieu Arnold
no flags Details | Diff
libperl.so.diff (13.71 KB, patch)
2014-12-10 08:41 UTC, Mathieu Arnold
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer 2014-12-09 12:05:42 UTC
Created attachment 150396 [details]
libperl.so.diff

So that pkg upgrade does the right thing.

Doing the exp-run with bulk -t would be nice (so that the added bit to qa.sh is ran)
Comment 1 Mathieu Arnold freebsd_committer 2014-12-09 16:03:06 UTC
Created attachment 150403 [details]
libperl.so.diff
Comment 2 Antoine Brodin freebsd_committer 2014-12-09 22:50:31 UTC
Take for exp-run
Comment 3 Antoine Brodin freebsd_committer 2014-12-10 06:48:35 UTC
Fist try:

http://package18.nyi.freebsd.org/build.html?mastername=101amd64-default-PR195821&build=2014-12-10_00h00m25s

I will relaunch it with those 2 lines added to the qa check:

                # No results presents a blank line
                [ -z "${f}" ] && continue
Comment 4 Mathieu Arnold freebsd_committer 2014-12-10 08:41:13 UTC
Created attachment 150422 [details]
libperl.so.diff

Add the -z $f bit.
Comment 5 Antoine Brodin freebsd_committer 2014-12-11 18:08:39 UTC
On 10.1 amd64 there are 2 new qa errors:

+ {"origin"=>"editors/p5-Padre", "pkgname"=>"p5-Padre-1.00_2", "phase"=>"stage-qa", "errortype"=>"stage"}
+ {"origin"=>"security/p5-openxpki", "pkgname"=>"p5-openxpki-0.25.0.1", "phase"=>"stage-qa", "errortype"=>"stage"}

failure logs:

http://package18.nyi.freebsd.org/data/101amd64-default-PR195821/2014-12-10_06h51m11s/logs/errors/p5-Padre-1.00_2.log
http://package18.nyi.freebsd.org/data/101amd64-default-PR195821/2014-12-10_06h51m11s/logs/errors/p5-openxpki-0.25.0.1.log
Comment 6 commit-hook freebsd_committer 2014-12-17 13:22:47 UTC
A commit references this bug:

Author: mat
Date: Wed Dec 17 13:22:01 UTC 2014
New revision: 374847
URL: https://svnweb.freebsd.org/changeset/ports/374847

Log:
  Make Perl link all .so it builds with libperl.so.

  It makes upgrading from one Perl major version to another way easier.  For
  binary package users, it means pkg upgrade will detect the libperl.so.x.yy
  change, and reinstall the affected packages.  For users using ports, it will
  save rebuild time as it's easier to detect what ports really need to be
  rebuilt.

  PR:		195821
  Differential Revision: https://reviews.freebsd.org/D1241
  Submitted by:	mat
  Reviewed by:	antoine, bdrewery
  Exp-run by:	antoine
  With hat:	perl
  Sponsored by:	Absolight

Changes:
  head/CHANGES
  head/Mk/Scripts/qa.sh
  head/Mk/Uses/perl5.mk
  head/UPDATING
  head/lang/perl5.14/Makefile
  head/lang/perl5.14/files/patch-Makefile.SH
  head/lang/perl5.16/Makefile
  head/lang/perl5.16/files/patch-Makefile.SH
  head/lang/perl5.18/Makefile
  head/lang/perl5.18/files/patch-Makefile.SH
  head/lang/perl5.20/Makefile
  head/lang/perl5.20/files/patch-Makefile.SH