Bug 195846 - [PATCH] dns/unbound: Forcibly deletes /var/run/unbound on deinstall
Summary: [PATCH] dns/unbound: Forcibly deletes /var/run/unbound on deinstall
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Sergey Matveychuk
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-10 09:37 UTC by Ollivier Robert
Modified: 2014-12-10 13:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sem)


Attachments
Diff to remove the bad line. (375 bytes, patch)
2014-12-10 09:37 UTC, Ollivier Robert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ollivier Robert freebsd_committer 2014-12-10 09:37:50 UTC
Created attachment 150424 [details]
Diff to remove the bad line.

pkg-plist has that line at the end:
@unexec rm -fr /var/run/unbound

which means that overtime you upgrade the package, you lose unbound.pid for the currently running binary.
Comment 1 Bugzilla Automation freebsd_committer 2014-12-10 09:37:50 UTC
Auto-assigned to maintainer sem@FreeBSD.org
Comment 2 Sergey Matveychuk freebsd_committer 2014-12-10 13:39:19 UTC
I don't agree with the patch. I'll change @exec rm... with @dirrmtry macro.
Comment 3 Sergey Matveychuk freebsd_committer 2014-12-10 13:42:59 UTC
OK. I see it's obsolated. So you're right, I'll remove the line.
Comment 4 Sergey Matveychuk freebsd_committer 2014-12-10 13:45:07 UTC
Thanks
Comment 5 commit-hook freebsd_committer 2014-12-10 13:45:17 UTC
A commit references this bug:

Author: sem
Date: Wed Dec 10 13:44:52 UTC 2014
New revision: 374456
URL: https://svnweb.freebsd.org/changeset/ports/374456

Log:
  - Do not remove /var/run/unbound for smooth upgrading.

  PR:		195846
  Submitted by:	roberto

Changes:
  head/dns/unbound/Makefile
  head/dns/unbound/pkg-plist