Bug 195895 - [MAINTAINER] games/pioneer: fix compiler error after 2014.12.03 changes
Summary: [MAINTAINER] games/pioneer: fix compiler error after 2014.12.03 changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-11 17:12 UTC by lightside
Modified: 2014-12-11 23:07 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (since 373736 revision) (989 bytes, patch)
2014-12-11 17:12 UTC, Bugzilla Automation
no flags Details | Diff
The poudriere testport log (FreeBSD 10 i386) (26.46 KB, application/x-zip-compressed)
2014-12-11 17:13 UTC, lightside
no flags Details
The poudriere testport log (FreeBSD 10 amd64) (26.45 KB, application/x-zip-compressed)
2014-12-11 17:13 UTC, lightside
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2014-12-11 17:12:19 UTC
Created attachment 150478 [details]
Proposed patch (since 373736 revision)

The pkg-fallout sent following error logs for games/pioneer port on 2014.12.11 date:
FreeBSD 10 i386:
http://beefy1.isc.freebsd.org/data/10i386-default/2014-12-11_02h51m13s/logs/pioneer-0.0.20141128.log
FreeBSD 10 amd64:
http://beefy2.isc.freebsd.org/data/10amd64-default/2014-12-11_03h33m01s/logs/pioneer-0.0.20141128.log

While the port successfully built before:
FreeBSD 10 i386:
http://beefy1.isc.freebsd.org/data/10i386-default/2014-12-03_03h54m18s/logs/pioneer-0.0.20141128.log
FreeBSD 10 amd64:
http://beefy2.isc.freebsd.org/data/10amd64-default/2014-12-03_04h02m17s/logs/pioneer-0.0.20141128.log

The attached patch fixes mentioned error, related to std::max matching function.
Also changed .tar.gz to ${EXTRACT_SUFX}.
Comment 1 lightside 2014-12-11 17:13:07 UTC
Created attachment 150479 [details]
The poudriere testport log (FreeBSD 10 i386)
Comment 2 lightside 2014-12-11 17:13:47 UTC
Created attachment 150480 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment 3 lightside 2014-12-11 18:23:51 UTC
Looks like, it was print/freetype2 v2.5.4 port update, which caused this, based on other submitted bug reports.
Comment 4 Dmitry Marakasov freebsd_committer 2014-12-11 18:53:58 UTC
Yes. See https://github.com/pioneerspacesim/pioneer/pull/3273
Comment 5 lightside 2014-12-11 19:28:15 UTC
(In reply to Dmitry Marakasov from comment #4)
> Yes. See https://github.com/pioneerspacesim/pioneer/pull/3273

Thanks for Git pull request to upstream. Apart, there is no need for (unsigned int) for following variables:
bmStrokeGlyph->bitmap.width
bmStrokeGlyph->bitmap.rows

They already has "unsigned int" type:
http://www.freetype.org/freetype2/docs/reference/ft2-basic_types.html#FT_Bitmap

The new update of this port will require to remove graphics/libGLU build dependency, because of GLEW removal:
https://github.com/pioneerspacesim/pioneer/commit/a3d8985
As well as, GLEW license.
Comment 6 lightside 2014-12-11 19:38:18 UTC
(In reply to lightside from comment #5)
> Apart, there is no need for
> (unsigned int) for following variables:
> bmStrokeGlyph->bitmap.width
> bmStrokeGlyph->bitmap.rows
> 
> They already has "unsigned int" type:
> http://www.freetype.org/freetype2/docs/reference/ft2-basic_types.
> html#FT_Bitmap

I understood, this is needed to support previous Freetype2 versions.
Comment 7 commit-hook freebsd_committer 2014-12-11 23:06:44 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Dec 11 23:06:10 UTC 2014
New revision: 374554
URL: https://svnweb.freebsd.org/changeset/ports/374554

Log:
  - Fix build with new freetype

  PR:		195895
  Submitted by:	lightside@gmx.com (maintainer)

Changes:
  head/games/pioneer/Makefile