Bug 195896 - [revive port] devel/py-gitpython: Resurrect previously deleted port
Summary: [revive port] devel/py-gitpython: Resurrect previously deleted port
Status: Closed DUPLICATE of bug 199335
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: easy, needs-qa, patch
: 191794 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-12-11 17:39 UTC by mike
Modified: 2015-06-25 02:30 UTC (History)
5 users (show)

See Also:


Attachments
port shar file (1.90 KB, application/x-shar)
2014-12-11 17:39 UTC, mike
no flags Details
updated patches for py-gitpython (2.58 KB, patch)
2014-12-13 01:04 UTC, mike
no flags Details | Diff
svn diff for both py-gitpython and py-gitdb (3.50 KB, patch)
2014-12-18 00:58 UTC, mike
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mike 2014-12-11 17:39:54 UTC
Created attachment 150481 [details]
port shar file

resurrecting the gitpython port, it was removed earlier this year. The project seems to have moved from gitorious to github.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-12-11 20:05:12 UTC
Fix category name.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-11 22:35:01 UTC
Thanks for your submission Mike!

On first review of the attached patch, the following changes are needed:

* Lowercase PORTNAME
* New or resurrected ports require a MAINTAINER (not ports@freebsd.org)
* Add LICENSE and LICENSE_FILE
* GitPython wants ['gitdb >= 0.6.0'], update RUN_DEPENDS to match [1]
* USE_PYDISTUTILS and PYDISTUTILS_AUTOPLIST have been deprecated. Instead use:

  USES=python[:version] and USE_PYTHON= feature1 feature2 

  See other Python ports for example usage.

For reference, the port was originally removed in this changeset:

https://svnweb.freebsd.org/ports?view=revision&revision=347472

[1] https://github.com/gitpython-developers/GitPython/blob/0.3/setup.py#L69
Comment 3 mike 2014-12-12 00:18:52 UTC
Is there a port maintainer I can use, besides ports@freebsd.org?
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-12 02:03:37 UTC
It's normal and expected that a submitter of a new or revived port nominate themselves as maintainer. You can find more info about port maintainership here:

https://www.freebsd.org/doc/en_US.ISO8859-1/articles/contributing-ports/maintain-port.html

Hope you take up the challenge! :)
Comment 5 mike 2014-12-13 01:04:21 UTC
Created attachment 150519 [details]
updated patches for py-gitpython

Thanks Kubilay! I'm up for the challenge :)

Here is the updated shar with your recommendations. I ended up switched to CHEESESHOP as well.

Consequentially, I had to create a port-bump for py-gitdb. Should I file that as a separate bug report?
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-15 08:36:21 UTC
Great to hear Mike :)

Replace the attached shar with an svn diff (or diff -u) patch and include the PORTREVISION bump in there.
Comment 7 mike 2014-12-18 00:58:47 UTC
Created attachment 150703 [details]
svn diff for both py-gitpython and py-gitdb

Here is the svn diff for py-gitpython and py-gitdb

py-gitpython is a full port, and py-gitdb is a port version bump for the existing port.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-18 11:09:21 UTC
*** Bug 191794 has been marked as a duplicate of this bug. ***
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-27 05:19:19 UTC
Comment on attachment 150703 [details]
svn diff for both py-gitpython and py-gitdb

Wen, do you mind approving the update for devel/py-gitdb please
Comment 10 Kubilay Kocak freebsd_committer freebsd_triage 2015-01-27 05:20:53 UTC
Mike, will take care of this issue once devel/py-gitdb part of your patch is approved. Apologies for the delay
Comment 11 Wen Heping freebsd_committer freebsd_triage 2015-01-27 13:02:43 UTC
(In reply to Kubilay Kocak from comment #9)
Approved.

Thank you !

wen
Comment 12 Kubilay Kocak freebsd_committer freebsd_triage 2015-06-25 02:30:24 UTC
Committed in r390304 [1]

Resurrect devel/py-gitpython
- Update to upstream version 1.0.1
- Maxim Filimonov <che@bein.link> takes maintainership
- Update WWW: Project is now hosted on github

PR:		199335
Differential Revision:	https://reviews.freebsd.org/D2659
Submitted by:	che@bein.link (maintainer)
Reviewed by:	koobs

[1] https://svnweb.freebsd.org/changeset/ports/390304

*** This bug has been marked as a duplicate of bug 199335 ***