Bug 195908 - [patch] math/libqalculate: Fix build without NLS
Summary: [patch] math/libqalculate: Fix build without NLS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-12 02:06 UTC by Kevin Zheng
Modified: 2015-02-16 21:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jhale)

Attachments
Patch to fix build without NLS (612 bytes, patch)
2014-12-12 02:06 UTC, Kevin Zheng 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2014-12-12 02:06:42 UTC 
Created attachment 150494 [details]
Patch to fix build without NLS

math/libqalculate fails to build without NLS. It appears that gettext must be supplied as a dependency all the time, or `configure` will fail.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-12 02:06:42 UTC 
Auto-assigned to maintainer jhale@FreeBSD.org
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-16 17:59:49 UTC 
Testing @work. I can reproduce the build-fail with NLS off.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-16 19:18:31 UTC 
Fixed in r379103, thanks for the patch.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2015-02-16 20:57:43 UTC 
Fix breaks case with NLS on.

Testing fix suggested by tijl.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-02-16 21:20:17 UTC 
A commit references this bug:

Author: pi
Date: Mon Feb 16 21:19:26 UTC 2015
New revision: 379112
URL: https://svnweb.freebsd.org/changeset/ports/379112

Log:
  math/libqalculate: really fix build in poudriere with both NLS cases

  PR:		195908
  Submitted by:	tijl

Changes:
  head/math/libqalculate/Makefile