Bug 195911 - [PATCH] sysutils/munin-common: add Python knob
Summary: [PATCH] sysutils/munin-common: add Python knob
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-12 06:31 UTC by takefu
Modified: 2015-02-17 09:51 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)

Attachments
munin.patch (25.98 KB, patch)
2014-12-12 06:31 UTC, takefu 		no flags Details | Diff
munin-common.patch (11.44 KB, patch)
2014-12-17 03:04 UTC, takefu 		no flags Details | Diff
munin-master.patch (6.67 KB, patch)
2014-12-17 03:06 UTC, takefu 		no flags Details | Diff
munin-node.patch (3.16 KB, patch)
2014-12-17 03:08 UTC, takefu 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2014-12-12 06:31:48 UTC 
Created attachment 150501 [details]
munin.patch

munin-common
 add IPv6 knob
 add Creating $DBDIR
 fix SNMP plugin

munin-master
 add CRONTAB e-mail address specified
 fix %%ETCDIR%%/static %%ETCDIR%%/templates abolition

munin-node
 add PYTHON IPV6 knob
 fix plugins.conf Miscellaneous changes
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-12 06:31:48 UTC 
Auto-assigned to maintainer mat@FreeBSD.org
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2014-12-12 09:21:04 UTC 
This patch does way too many things.

Could you please remove the email address selection, the ETCDIR changes, make the IPV6 changes unconditional.

You talk about plugins.conf and python, but there's no such changes I can find in the diff.

And please, generate *one* diff with, say, svn diff, and not like you did, which I think, is concatenating different patches, which I'm going to have a hard time applying.
Comment 3 takefu 2014-12-17 03:04:24 UTC 
Created attachment 150669 [details]
munin-common.patch

Add SNMP domain in plugin
Comment 4 takefu 2014-12-17 03:06:44 UTC 
Created attachment 150670 [details]
munin-master.patch

Add IPV6 knob
%%ETCDIR%% organize
Comment 5 takefu 2014-12-17 03:08:22 UTC 
Created attachment 150671 [details]
munin-node.patch

Add python knob
Comment 6 Mathieu Arnold freebsd_committer freebsd_triage 2015-01-19 18:31:04 UTC 
Could you provide a patch with only the python and snmp changes.  That means, do not provide any other change, no IPV6, no ETCDIR.

Also, please, provide only *one* patch generated by svn, not manually.