Bug 195940 - games/primateplunge: no longer builds in bulk due to license change
Summary: games/primateplunge: no longer builds in bulk due to license change
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-13 07:53 UTC by John Marino
Modified: 2014-12-15 13:20 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2014-12-13 07:53:19 UTC
this commit[1] by amdmi3 created a situation where the game no longer can build in a batch due to license requirements:

License UDEVGAME needs confirmation, but BATCH is defined

Is this intentional?


[1] http://www.freshports.org/commit.php?category=games&port=primateplunge&files=yes&message_id=201412020415.sB24FHiC062569@svn.freebsd.org
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-14 23:14:42 UTC
Of course.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-12-14 23:22:21 UTC
Well, given that every other instance of this situation I've seen, it's been a mistake or lack of understanding of the license framework, it's certainly not an obvious answer.  Normally people don't intentionally stop binary packaging.

Maybe it would help to add a comment to makefile that license has to be manually accepted so the question doesn't come up again.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2014-12-15 02:09:04 UTC
I don't see need for an extra comment here, as it's straightforward and unambiguous use of license framework and there's already a comment saying that the field was intentionally left empty. If there are, as you say, many enough cases of incorrect license framework use, probably the framework should be improved to be less prone to misuse.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-12-15 13:20:38 UTC
well, do what you want.  That fact *_perms is set to nothing does make it seem intentional.  Usually people that change the license don't set that at all, because they don't know they have to.

I was only interested because dports filters out ports where their packages don't build by default.  The consequence of this license change is that primateplunge has been removed from DragonFly's ports.  I just wanted to make sure the license change was intentional before doing that drastic action.

I'm closing the PR.