Bug 195969 - Fix an iconv related problem in japanese/ebview-gtk2
Summary: Fix an iconv related problem in japanese/ebview-gtk2
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-14 17:35 UTC by sakaue.mamoru
Modified: 2015-01-15 08:51 UTC (History)
1 user (show)

See Also:


Attachments
Add iconv to USES (453 bytes, patch)
2014-12-14 17:35 UTC, sakaue.mamoru
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sakaue.mamoru 2014-12-14 17:35:55 UTC
Created attachment 150575 [details]
Add iconv to USES

Build of japanese/ebview fails in systems (10 or later) which have iconv in the base system when converters/libiconv is installed. This can be resolved by adding "iconv" to USES. This modification will be harmless to the older systems because the dependencies on gettext and gmake had resulted in the dependency on converters/libiconv in those systems.

[FAILED BUILD LOG] (Sun Dec  7 13:51:20 JST 2014)
## LANG must be reset to avoid confusion of /usr/bin/sed.
# env LANG= make -C /usr/ports/japanese/ebview
....(skip)....
cc -I/usr/local/include/gtk-1.2 -I/usr/local/include/glib-1.2 -I/usr/local/lib/glib/include -D_REENTRANT -I/usr/local/include -I/usr/local/include/gtk-1.2 -I/usr/local/include/glib-1.2 -I/usr/local/lib/glib/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -O2 -pipe -fstack-protector -fno-strict-aliasing -std=gnu89 -fstack-protector -o ebview dictgroup.o dicttext.o link.o preference.o selection.o dialog.o eb.o history.o mainmenu.o statusbar.o dictbar.o dictheading.o ebview.o menu.o render.o select.o ending.o popup.o dump.o external.o websearch.o weblist.o pixmap.o xml.o xmlinternal.o misc.o canvas.o contentarea.o shortcut.o shortcutfunc.o font.o multi.o jcode.o  -L/usr/local/lib -lgtk -lgdk -lgmodule -lgthread -lglib -lpthread -lintl -lm -lgdk_imlib -lgtk -lgdk -lgmodule -lglib -lintl /usr/local/lib/libXi.so /usr/local/lib/libXext.so /usr/local/lib/libX11.so -lm -leb -lz -lintl -Wl,--rpath -Wl,/usr/local/lib -Wl,--rpath -Wl,/usr/local/lib
eb.o: In function `ebook_search2':
eb.c:(.text+0x1348): undefined reference to `libiconv_open'
eb.c:(.text+0x13ae): undefined reference to `libiconv'
eb.c:(.text+0x13b9): undefined reference to `libiconv_close'
dump.o: In function `hex_dump_page':
dump.c:(.text+0x7b3): undefined reference to `libiconv_open'
dump.c:(.text+0x815): undefined reference to `libiconv'
dump.c:(.text+0x824): undefined reference to `libiconv_close'
websearch.o: In function `web_search':
websearch.c:(.text+0x107): undefined reference to `libiconv_open'
websearch.c:(.text+0x170): undefined reference to `libiconv'
websearch.c:(.text+0x178): undefined reference to `libiconv_close'
contentarea.o: In function `char_kind':
contentarea.c:(.text+0x1a4): undefined reference to `libiconv_open'
contentarea.c:(.text+0x1f3): undefined reference to `libiconv'
contentarea.c:(.text+0x2b3): undefined reference to `libiconv_close'
jcode.o: In function `do_iconv':
jcode.c:(.text+0xc2): undefined reference to `libiconv_open'
jcode.c:(.text+0x14a): undefined reference to `libiconv'
jcode.c:(.text+0x155): undefined reference to `libiconv_close'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:283: recipe for target 'ebview' failed
gmake[5]: *** [ebview] Error 1
gmake[5]: Leaving directory '/usr/ports/japanese/ebview/work/ebview-0.2.1/src'
Makefile:211: recipe for target 'all-recursive' failed
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory '/usr/ports/japanese/ebview/work/ebview-0.2.1'
Makefile:147: recipe for target 'all' failed
gmake[3]: *** [all] Error 2
gmake[3]: Leaving directory '/usr/ports/japanese/ebview/work/ebview-0.2.1'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[2]: stopped in /usr/ports/japanese/ebview
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/japanese/ebview
*** Error code 1

Stop.
make: stopped in /usr/ports/japanese/ebview
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2015-01-13 21:23:15 UTC
Hi,

I've tested this port as is and am been unable to reproduce the problem in poudriere.

On the build cluster too the port does build successfully:

http://beefy2.isc.freebsd.org/bulk/10amd64-default/latest-per-pkg/ja-ebview-gtk2-0.3.6_18.log

I suspect there's something wrong on your system.

This does not mean that the port does not need the iconv USES, but Do you have some more evidence that the problem affects more systems or a specific use case I can reproduce?
Comment 2 sakaue.mamoru 2015-01-15 04:14:49 UTC
The symptom was only for japanese/ebview. I had never tested japanese/ebview-gtk2. The platform was 10.0-RELEASE (amd64) and 10.1-RELEASE (amd64). Since japanese/ebview was removed from the latest Ports tree, the issue has disappeared.

Thanks.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2015-01-15 08:51:35 UTC
Thanks for the feedback.

I tested ebview-gtk2 since that was in the object line. Sorry for the misunderstanding.

Anyway I'm closing the PR since it is not applicable anymore.