Bug 196029 - sysutils/lsof does not compile: implicit declaration of function 'VOP_FSYNC' (affects sysutils/htop)
Summary: sysutils/lsof does not compile: implicit declaration of function 'VOP_FSYNC' ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 15:26 UTC by Thomas Schweikle
Modified: 2016-10-09 22:05 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schweikle 2014-12-16 15:26:15 UTC
First system:
# uname -a
FreeBSD fbsd12-64.bfs.de 11.0-CURRENT FreeBSD 11.0-CURRENT #124 r275815: Tue Dec 16 07:36:37 CET 2014     root@fbsd12-64.bfs.de:/usr/obj/usr/src/sys/FBSD12-64  amd64

# svn info
Path: .
Working Copy Root Path: /usr/ports
URL: https://svn0.us-east.freebsd.org/ports/head
Repository Root: https://svn0.us-east.freebsd.org/ports
Repository UUID: 35697150-7ecd-e111-bb59-0022644237b5
Revision: 374781
Node Kind: directory
Schedule: normal
Last Changed Author: timur
Last Changed Rev: 374781
Last Changed Date: 2014-12-16 01:48:57 +0100 (Tue, 16 Dec 2014)

Second system:
# uname -a
FreeBSD test-sct-bf-muc.bfs.de 10.1-STABLE FreeBSD 10.1-STABLE #4 r275815: Tue Dec 16 06:09:43 CET 2014     root@test-sct-bf-muc.bfs.de:/usr/obj/usr/src/sys/TEST-SCT-BF-MUC  amd64

# svn info
Path: .
Working Copy Root Path: /usr/ports
URL: https://svn0.us-east.freebsd.org/ports/head
Repository Root: https://svn0.us-east.freebsd.org/ports
Repository UUID: 35697150-7ecd-e111-bb59-0022644237b5
Revision: 374781
Node Kind: directory
Schedule: normal
Last Changed Author: timur
Last Changed Rev: 374781
Last Changed Date: 2014-12-16 01:48:57 +0100 (Tue, 16 Dec 2014)


lsof / htop do not compile because of 
cc -pipe -fstack-protector -fno-strict-aliasing -DFREEBSDV=11000 -DHAS_ZFS -DHAS_CV_TIMEDWAIT_SBT -DHAS_V_LOCKF -D_SOLARIS_C_SOURCE
-O2 -I/usr/src/sys/cddl/compat/opensolaris -I/usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs -I/usr/src/sys/cddl/contrib/ope
nsolaris/uts/common/zmod -I/usr/src/sys/cddl/contrib/opensolaris/uts/common -I/usr/src/sys/cddl/contrib/opensolaris/common/zfs -I/us
r/src/sys/cddl/contrib/opensolaris/common -I/usr/ports/sysutils/lsof/work/lsof_4.88/lsof_4.88_src/usr/src/include -I`pwd` -c dnode2.
c
In file included from dnode2.c:55:
In file included from /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_znode.h:33:
In file included from /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_vfsops.h:31:
In file included from /usr/src/sys/cddl/compat/opensolaris/sys/vfs.h:37:
/usr/src/sys/cddl/compat/opensolaris/sys/vnode.h:257:10: warning: implicit declaration of function 'VOP_FSYNC' is invalid in C99 [-W
implicit-function-declaration]
        error = VOP_FSYNC(vp, MNT_WAIT, curthread);
                ^
1 warning generated.

And:
cc  -pipe -fstack-protector -fno-strict-aliasing -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR=\"11.0-CURRENT\" -I/usr/src/sys -O2 -c dproc.c
cc  -pipe -fstack-protector -fno-strict-aliasing -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR=\"11.0-CURRENT\" -I/usr/src/sys -O2 -c dsock.c
dsock.c:215:32: error: no member named 'sb_cc' in 'struct sockbuf'
                Lf->sz = (SZOFFTYPE)s.so_rcv.sb_cc;
                                    ~~~~~~~~ ^
dsock.c:217:32: error: no member named 'sb_cc' in 'struct sockbuf'
                Lf->sz = (SZOFFTYPE)s.so_snd.sb_cc;
                                    ~~~~~~~~ ^
dsock.c:219:33: error: no member named 'sb_cc' in 'struct sockbuf'
                Lf->sz = (SZOFFTYPE)(s.so_rcv.sb_cc + s.so_snd.sb_cc);
                                     ~~~~~~~~ ^
dsock.c:219:50: error: no member named 'sb_cc' in 'struct sockbuf'
                Lf->sz = (SZOFFTYPE)(s.so_rcv.sb_cc + s.so_snd.sb_cc);
                                                      ~~~~~~~~ ^
dsock.c:225:24: error: no member named 'sb_cc' in 'struct sockbuf'
        Lf->lts.rq = s.so_rcv.sb_cc;
                     ~~~~~~~~ ^
dsock.c:226:24: error: no member named 'sb_cc' in 'struct sockbuf'
        Lf->lts.sq = s.so_snd.sb_cc;
                     ~~~~~~~~ ^
6 errors generated.
*** [dsock.o] Error code 1

make[1]: stopped in /usr/ports/sysutils/lsof/work/lsof_4.88/lsof_4.88_src
1 error

make[1]: stopped in /usr/ports/sysutils/lsof/work/lsof_4.88/lsof_4.88_src
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/lsof


htop does not compile, because it depends on lsof.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-12-17 00:14:09 UTC
Fix Summary and notify maintainer.
Comment 2 Larry Rosenman freebsd_committer freebsd_triage 2014-12-17 00:33:22 UTC
see also https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195679
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2014-12-17 17:27:34 UTC
patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195679 will fix this.
Comment 4 Larry Rosenman freebsd_committer freebsd_triage 2014-12-17 18:38:00 UTC
ports r374867 or higher should fix this.
Comment 5 Larry Rosenman freebsd_committer freebsd_triage 2014-12-19 19:27:15 UTC
This should be fixed now with 4.89B

Please close the PR.
Comment 6 John Marino freebsd_committer freebsd_triage 2015-02-06 17:24:50 UTC
closed per maintainer request
Comment 7 emz 2016-10-08 10:44:20 UTC
Got this just now on FreeBSD 11.0-RC3 #0 r305786 / ports r423493:

--- dnode2.o ---
In file included from dnode2.c:55:
In file included from /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_znode.h:32:
In file included from /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu.h:47:
In file included from /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_context.h:73:
In file included from /usr/src/sys/cddl/compat/opensolaris/sys/vfs.h:37:
/usr/src/sys/cddl/compat/opensolaris/sys/vnode.h:244:10: warning: implicit declaration of function 'VOP_FSYNC' is invalid in C99 [-Wimplicit-function-declaration]
        error = VOP_FSYNC(vp, MNT_WAIT, curthread);
                ^
1 warning generated.
--- lib/liblsof.a ---
--- cvfs.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c cvfs.c -o cvfs.o
--- dvch.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c dvch.c -o dvch.o
--- fino.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c fino.c -o fino.o
--- isfn.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c isfn.c -o isfn.o
--- lkud.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c lkud.c -o lkud.o
--- pdvn.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c pdvn.c -o pdvn.o
--- prfp.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c prfp.c -o prfp.o
--- ptti.o ---
--- rdev.o ---
--- ptti.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c ptti.c -o ptti.o
--- rdev.o ---
cc  -pipe -fstack-protector -fno-strict-aliasing -DNEEDS_BOOL_TYPEDEF -DHASTASKS -DHAS_PAUSE_SBT -DHASEFFNLINK=i_effnlink -DHASF_VNODE -DHAS_FILEDESCENT -DHAS_TMPFS -DHASWCTYPE_H -DHASSBSTATE -DHAS_KVM_VNODE -DHAS_UFS1_2 -DHAS_VM_MEMATTR_T -DHAS_CDEV2PRIV -DHAS_NO_SI_UDEV -DHAS_SYS_SX_H -DHASFUSEFS -DHAS_ZFS -DHAS_V_LOCKF -DHAS_LOCKF_ENTRY -DHAS_NO_6PORT -DHAS_NO_6PPCB -DNEEDS_BOOLEAN_T -DHAS_SB_CCC -DHAS_FDESCENTTBL -DFREEBSDV=11000 -DHASFDESCFS=2 -DHASPSEUDOFS -DHASNULLFS -DHASIPv6 -DHASUTMPX -DHAS_STRFTIME -DLSOF_VSTR="11.0-RC3" -I/usr/src/sys -O2 -c rdev.c -o rdev.o
--- dnode.o ---
dnode.c:914:13: error: no member named 'i_dev' in 'struct inode'
            if (i->i_dev
                ~  ^
dnode.c:924:27: error: no member named 'i_dev' in 'struct inode'
                dev = Dev2Udev((KA_T)i->i_dev);
                                     ~  ^
2 errors generated.
*** [dnode.o] Error code 1

make[1]: stopped in /usr/ports/sysutils/lsof/work/lsof_4.90G.freebsd
--- lib/liblsof.a ---
A failure has been detected in another branch of the parallel make

make[2]: stopped in /usr/ports/sysutils/lsof/work/lsof_4.90G.freebsd/lib
*** [lib/liblsof.a] Error code 2

make[1]: stopped in /usr/ports/sysutils/lsof/work/lsof_4.90G.freebsd
2 errors

make[1]: stopped in /usr/ports/sysutils/lsof/work/lsof_4.90G.freebsd
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/lsof

===>>> make build failed for sysutils/lsof
===>>> Aborting update

===>>> Update for sysutils/lsof failed
===>>> Aborting update

===>>> The following actions were performed:
        Re-installation of subversion-1.9.4


===>>> You can restart from the point of failure with this command line:
       portmaster <flags> sysutils/lsof
Comment 8 emz 2016-10-08 10:46:17 UTC
Oh, sorry, I realized it's a warning.
Comment 9 Larry Rosenman freebsd_committer freebsd_triage 2016-10-09 22:05:50 UTC
make sure your /usr/src and world are in sync.  The i_dev error is fixed with current sources/world.