Bug 196101 - [MAINTAINER UPDATE] x11/x3270: Update to version 3.3.15ga7
Summary: [MAINTAINER UPDATE] x11/x3270: Update to version 3.3.15ga7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-18 17:47 UTC by ecrist
Modified: 2015-01-13 19:16 UTC (History)
2 users (show)

See Also:
ecrist: maintainer-feedback+


Attachments
port update patch (799 bytes, patch)
2014-12-18 17:47 UTC, ecrist
no flags Details | Diff
Revised patch (3.08 KB, patch)
2015-01-13 12:56 UTC, Guido Falsi
madpilot: maintainer-approval? (ecrist)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ecrist 2014-12-18 17:47:40 UTC
Created attachment 150731 [details]
port update patch

Attached patch updates x11/x3270 to the latest release version.
Comment 1 Guido Falsi freebsd_committer 2015-01-13 12:56:40 UTC
Created attachment 151551 [details]
Revised patch

Hi,

I have made some further improvements to the port.

The code handling the fonts is quite old. There are new easier facilities in the ports tree for that now.

I've converted the port to use the @fontsdir keyword which internally works almost as the old code.

I also made the port install fonts to it's own directory.

I also removed the @dirrm which is deprecated, and mostly unneeded. One only needs the new @dir directive for empty directories or when special permissions are required on a directory.

Can you run test the port with my changes and approve the patch if it works?

I'm unable to run test it properly, since I miss an host system to connect to.
Comment 2 ecrist 2015-01-13 17:21:46 UTC
Looks OK to me.  The URL for the download is different, but if it tests as working, go ahead.
Comment 3 commit-hook freebsd_committer 2015-01-13 19:16:04 UTC
A commit references this bug:

Author: madpilot
Date: Tue Jan 13 19:16:00 UTC 2015
New revision: 376982
URL: https://svnweb.freebsd.org/changeset/ports/376982

Log:
  - Update to 3.3.15ga7
  - Move fonts to own directory
  - Modernize plist

  While here, silence one portlint warning.

  PR:		196101
  Submitted by:	ecrist at secure-computing.net (maintainer)

Changes:
  head/x11/x3270/Makefile
  head/x11/x3270/distinfo
  head/x11/x3270/pkg-plist
Comment 4 Guido Falsi freebsd_committer 2015-01-13 19:16:19 UTC
Commited. Thanks!