Bug 196162 - net/liveMedia ignores PREFIX [patch]
Summary: net/liveMedia ignores PREFIX [patch]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-20 17:50 UTC by Mikhail T.
Modified: 2014-12-23 16:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)

Attachments
"Brute force" correct PREFIX in generated Makefiles after configure (436 bytes, patch)
2014-12-20 17:50 UTC, Mikhail T. 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail T. 2014-12-20 17:50:36 UTC 
Created attachment 150814 [details]
"Brute force" correct PREFIX in generated Makefiles after configure

My prefix is set to /opt here, but the port staged everything into ${STAGEDIR}/usr/local anyway. Installation failed.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-20 17:50:36 UTC 
Auto-assigned to maintainer multimedia@FreeBSD.org
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2014-12-20 18:33:00 UTC 
Did it respect PREFIX before?

No worries, I don't want to reject this generally, just being curious.
Comment 3 Mikhail T. 2014-12-21 13:12:17 UTC 
(In reply to Thomas Zander from comment #2)
> Did it respect PREFIX before?

I didn't have this problem with the liveMedia-2014.11.29,2 -- not sure, when the bug appeared.

> No worries, I don't want to reject this generally, just being curious.

My patch may not be the best solution -- but it is a solution. The PREFIX is not part of CONFIGURE_ENV (nor of CONFIGURE_ARGS) -- maybe, that's a better direction to take. But mine works too...
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-12-23 13:18:44 UTC 
A commit references this bug:

Author: riggs
Date: Tue Dec 23 13:18:10 UTC 2014
New revision: 375322
URL: https://svnweb.freebsd.org/changeset/ports/375322

Log:
  - Ensure that PREFIX is respected
  - Pet portlint

  PR:		196162
  Submitted by:	mi@ALDAN.algebra.com

Changes:
  head/net/liveMedia/Makefile
  head/net/liveMedia/pkg-message
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2014-12-23 13:32:01 UTC 
It worries me that a project at some point decides to stop respecting PREFIX.

Committed, thx.
Comment 6 Mikhail T. 2014-12-23 14:54:59 UTC 
(In reply to Thomas Zander from comment #5)

Thank you, but why did you change PORTREVISION? The default install -- where /usr/local/ is the PREFIX anyway -- did not change. Does a small change to pkg-message justify having thousands of computers world-wide doing a rebuild?.. :-(
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2014-12-23 16:32:25 UTC 
Because part of the commit was also removing superfluous empty lines from pkg-message, as pointed out by portlint. That changes the package content for everyone, hence the bump.