Created attachment 150840 [details]
Upgrade graphic/lensfun to 0.3.0
Lensfun 0.3.0 was released the 2014-09-30 and brings new lens correction profiles, fix for many lens names, etc etc (http://lensfun.sourceforge.net/changelog/2014/09/30/Release-0.3.0-Changelog/). It also moved its build sys to cmake.
Here is a patch against HEAD to bump the port version. My tests with graphic/darktable shows that liblensfun.so seems to be ABI compatible, but maybe dependencies should be rebuild in doubt...
portlint is happy, and here's plist check result:
# make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
Fix typo in Summary and assign.
May I politely "bump" the issue? It's been more than a month...
Since last patch the Makefile changes
and has a PORTREVISION who breaks the
patch. The problem is minor.
Here is the poudriere log :
Now I have to test the port or "real" :)
(In reply to Matthieu Volat from comment #2)
> May I politely "bump" the issue? It's been more than a month...
I'm currently working on the update. Proposed patch has a number of problems (e.g. it installs useless auxiliary scripts, does not mention BUILD_AUXFUN option while still keeping libpng dependency, python:build in USES after they switched to CMake). Since lensfun.h was moved inside lenfsun subdirectory, all ports that use this library must be rechecked to see that they do not hardcode its location.
That said, no further attachments to this PR are necessary.
Final patch I'd want to commit is here: http://people.freebsd.org/~danfe/lensfun.diff
However, first I'd have to take care of the following ports. It seems that API changed and there are 4 failures:
Created attachment 153863 [details]
Fix hugin with lensfun 0.3
Thanks, if it can help, the hugin breakage is very easy to fix: it's just a removed correction model which was not used according to the corresponding log message in lensfun git log ( http://sourceforge.net/p/lensfun/code/ci/048eb3c4e562b8d3b00068f6f42c7900865d3358/ ).
Patch added, but maybe I should submit it to the hugin maintainer...
A commit references this bug:
Date: Tue Mar 31 08:08:54 UTC 2015
New revision: 382801
Update lensfun to version 0.3.0. It contains few changes making consumer
code incompatible with earlier versions; particularly, removal of CCI (the
Color Contribution Index of the lens, as defined by ISO 6728-83)  and
FOV1 ("field-of-view")  distortion model.
Four ports had to be patched to build against new lensfun (all fall under
`graphics' category): digikam-kde4, gimp-lensfun-plugin, hugin, rawstudio.
Submitted by: Matthieu Volat (heavily modified)
Exp-run by: antoine
Committed as of ports r382801, thanks for your submission!