Bug 196264 - [iwn] [patch]: few minor fixes
Summary: [iwn] [patch]: few minor fixes
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: wireless (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-wireless (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-25 11:43 UTC by Andriy Voskoboinyk
Modified: 2018-12-09 03:41 UTC (History)
1 user (show)

See Also:

Attachments
Remove check for c->ic_flags & IEEE80211_CHAN_PASSIVE (618 bytes, patch)
2014-12-25 11:43 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Few minor fixes (1.15 KB, patch)
2015-03-06 11:35 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Patch-v2.diff (2.00 KB, patch)
2015-03-08 09:46 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Patch-v2.diff (2.00 KB, patch)
2015-03-08 09:49 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Patch-v3.diff (untested) (3.97 KB, patch)
2015-05-12 20:45 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2014-12-25 11:43:12 UTC 
Created attachment 150952 [details]
Remove check for c->ic_flags & IEEE80211_CHAN_PASSIVE
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-03-06 11:35:26 UTC 
Created attachment 153892 [details]
Few minor fixes

- Add missing IWN_UNLOCK(sc).
- Remove redundant initialization in iwn_ioctl().
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-03-08 09:46:20 UTC 
Created attachment 153995 [details]
Patch-v2.diff

- Set maxfrags to IWN_MAX_SCATTER - 1 (first segment is used by the TX command)
- Remove redundant "not" from error string.
Comment 3 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-03-08 09:49:30 UTC 
Created attachment 153996 [details]
Patch-v2.diff

Mark previous patches as obsolete.
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-05-12 20:45:48 UTC 
Created attachment 156730 [details]
Patch-v3.diff (untested)

- Pass control frames to host.
- Do not set TX timer on error.
- Free node references for unsent frames on device stop.
Comment 5 Adrian Chadd freebsd_committer freebsd_triage 2015-05-13 01:16:33 UTC 
Hi,

Do you not have anything with iwn(4) hardware in it?
Comment 6 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-05-13 13:58:03 UTC 
(In reply to Adrian Chadd from comment #5)
No, I don't have such devices.
Comment 7 Adrian Chadd freebsd_committer freebsd_triage 2015-05-15 02:29:23 UTC 
Would you like a thinkpad with one in it?
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-05-16 05:59:30 UTC 
A commit references this bug:

Author: adrian
Date: Sat May 16 05:59:26 UTC 2015
New revision: 282999
URL: https://svnweb.freebsd.org/changeset/base/282999

Log:
  Various iwn(4) fixes.

  * simplify channel logic for determining RF gain setting in scan setup
  * don't set TX timer on error
  * free node references for unsent frames on device stop
  * set maxfrags to IWN_MAX_SCATTER-1 (first segment is used by TX command)
  * add missing IWN_UNLOCK() from interrupt path when the hardware
    disappears.
  * pass control frames to host
  * nitems() instead of local macro

  Tested:

  * Intel 5100, STA mode

  PR:		kern/196264
  Submitted by:	Andriy Voskoboinyk <s3erios@gmail.com>

Changes:
  head/sys/dev/iwn/if_iwn.c