Bug 196373 - [MAINTAINER] games/pioneer: Update to 0.0.20141230
Summary: [MAINTAINER] games/pioneer: Update to 0.0.20141230
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2014-12-30 05:39 UTC by lightside
Modified: 2015-01-21 04:17 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (since 375598 revision) (1.72 KB, patch)
2014-12-30 05:39 UTC, lightside
no flags Details | Diff
The poudriere testport log (FreeBSD 10 amd64) (26.62 KB, application/x-zip-compressed)
2014-12-30 05:40 UTC, lightside
no flags Details
Proposed patch (since 375598 revision) (1.89 KB, patch)
2015-01-21 01:16 UTC, lightside
no flags Details | Diff
The poudriere testport log (FreeBSD 10 amd64) (20.79 KB, application/x-7z-compressed)
2015-01-21 01:17 UTC, lightside
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2014-12-30 05:39:38 UTC
Created attachment 151102 [details]
Proposed patch (since 375598 revision)

Patch to update games/pioneer port from 0.0.20141128 to 0.0.20141230 version.

Look following link for changes:
https://github.com/pioneerspacesim/pioneer/compare/20141128...20141230

- Adapted PORTDOCS
- Removed sed patch for ${WRKSRC}/src/text/TextureFont.h file, because of upstream fixes
Comment 1 lightside 2014-12-30 05:40:09 UTC
Created attachment 151103 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-30 07:56:30 UTC
Thanks for your submission! On initial review:

- ${GH_PROJECT} (recently) defaults to ${PORTNAME}, no longer necessary
- ${WRKSRC} override is not necessary when using USE_GITHUB
- MASTER_SITES is not necessary when using USE_GITHUB

If you could update the patch that would be great.

Also:

- Attach portlint -AC output after addressing any valid warnings
Comment 3 lightside 2014-12-30 09:13:37 UTC
Hello, Kubilay Kocak.

(In reply to Kubilay Kocak from comment #2)
> Thanks for your submission! On initial review:
> 
> - ${GH_PROJECT} (recently) defaults to ${PORTNAME}, no longer necessary
> - ${WRKSRC} override is not necessary when using USE_GITHUB
> - MASTER_SITES is not necessary when using USE_GITHUB

This port doesn't use USE_GITHUB by intention (because of release methods). Look first PR #193213 about this.

(In reply to Kubilay Kocak from comment #2)
> - Attach portlint -AC output after addressing any valid warnings

# portlint -C
looks fine.

It was the same for -AC on first submission.

Thanks for attention.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-30 10:18:20 UTC
The canonical convention is still preferred, unless using GITHUB_RELEASE (See: Mk/bsd.sites.mk)
Comment 5 lightside 2014-12-30 11:02:43 UTC
(In reply to Kubilay Kocak from comment #4)
> The canonical convention is still preferred, unless using GITHUB_RELEASE
> (See: Mk/bsd.sites.mk)

It uses DISTVERSION in case of GITHUB_RELEASE (or GHR). There are no Git release tags named as 0.0.YYYYMMDD, they were created by intention also (in possibility to define version without using PORTEPOCH).
The current method was described inside of Mk/bsd.sites.mk before 2014.12.20 changes:
# GitHub files can also be obtained, without the need for any of the above, by doing:
#
# MASTER_SITES=	http://github.com/accountname/${PORTNAME}/archive/${PORTVERSION}.tar.gz?dummy=/

where I use GH_TAGNAME in case of PORTVERSION here.

Do I need to write some comment inside of Makefile about "Do not touch fetch methods, create your -devel port instead?". I don't think so, especially if these methods works already (for about 40 other ports also).
Maybe, in case of changes in release methods upstream and/or versioned release tags - the current fetch method could be changed, but not necessary.
Comment 6 lightside 2014-12-30 11:19:20 UTC
This port could also use USES=autoreconf, instead of USE_AUTOTOOLS, for the same effect, but with more dependencies. But there is no point in this for current moment.
Comment 7 lightside 2014-12-30 12:25:26 UTC
Other than this, this is just an update. The main purpose of current method is easy updates to release tags, without the need to define Git commits (with their own advantages and disadvantages).

Thanks for clarification about possible improvements.
Comment 8 lightside 2015-01-21 01:16:45 UTC
Created attachment 151939 [details]
Proposed patch (since 375598 revision)

Actually, the installed packages in case of USES=autoreconf are the same (devel/autoconf and devel/automake), so it is possible to change it.
The next update is planned near the end of the current month, where there is full changelog on developer's site, regardless of commit.
If there are issues with building on commiter's side, better tell about it here, because there are no pkg-fallout messages for previous version, which is technically the same (in terms of dependencies and C/C++ features used). There are issues (about support of lambda functions in tuple(s)) with using LLVM/Clang compiler, greater than v3.4.x (from ports) on FreeBSD 10, related to outdated libc++ in FreeBSD 10 base, which is outside of port's scope for FreeBSD release version or might require to use (updated) devel/libc++ port.
Comment 9 lightside 2015-01-21 01:17:10 UTC
Created attachment 151940 [details]
The poudriere testport log (FreeBSD 10 amd64)
Comment 10 commit-hook freebsd_committer 2015-01-21 04:17:44 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Jan 21 04:16:51 UTC 2015
New revision: 377569
URL: https://svnweb.freebsd.org/changeset/ports/377569

Log:
  - Update to 20141230

  PR:		196373
  Submitted by:	lightside@gmx.com (maintainer)

Changes:
  head/games/pioneer/Makefile
  head/games/pioneer/distinfo