Created attachment 151228 [details] The ports These ports add high quality CMU ARCTIC voices for Festival audio/festvox-cmu_us_awb_arctic audio/festvox-cmu_us_bdl_arctic audio/festvox-cmu_us_clb_arctic audio/festvox-cmu_us_jmk_arctic audio/festvox-cmu_us_rms_arctic audio/festvox-cmu_us_slt_arctic Patching of share/festical/lib/voices.scm is needed to make the voices work without additional commands.
Created attachment 151229 [details] The ports Corrected dependencies
Created attachment 151286 [details] The ports Added LICENSE section. Static plists would be approx. 5M in size -- not sure if that is necessary.
Created attachment 152193 [details] audio/festvox-cmu_us_awb_arctic
Created attachment 152194 [details] audio/festvox-cmu_us_bdl_arctic
Created attachment 152195 [details] audio/festvox-cmu_us_clb_arctic
Created attachment 152196 [details] audio/festvox-cmu_us_jmk_arctic
Created attachment 152197 [details] audio/festvox-cmu_us_rms_arctic
Created attachment 152198 [details] audio/festvox-cmu_us_slt_arctic
Created attachment 163301 [details] audio/festvox-cmu_us_slt_arctic
Created attachment 163302 [details] audio/festvox-cmu_us_awb_arctic
Created attachment 163303 [details] audio/festvox-cmu_us_bdl_arctic
Created attachment 163304 [details] audio/festvox-cmu_us_clb_arctic
Created attachment 163305 [details] audio/festvox-cmu_us_jmk_arctic
Created attachment 163306 [details] audio/festvox-cmu_us_rms_arctic
Created attachment 163307 [details] portlint output
Created attachment 163308 [details] poudriere: audio/festvox-cmu_us_awb_arctic
Created attachment 163309 [details] poudriere: audio/festvox-cmu_us_bdl_arctic
Created attachment 163310 [details] poudriere: audio/festvox-cmu_us_clb_arctic
Created attachment 163311 [details] poudriere: audio/festvox-cmu_us_jmk_arctic
Created attachment 163312 [details] poudriere: audio/festvox-cmu_us_rms_arctic
Created attachment 163313 [details] poudriere: audio/festvox-cmu_us_slt_arctic
I had a look at the ports and I suggest the following changes: - Would it be possible to use a autogenerated pkg-plist instead of the static one ? It saves lots of "ports tree space" - The way they are coded right now they do not pass portlint -AC at all. Any chance to fix that ?
One example of a dynamic PLIST can be found in devel/avr-libc/Makefile.
I will try dynamic plist generation. Not sure about portlint: as far as I know, it can give false-positives for master-slave port setups.
Created attachment 163442 [details] example for dynamic plist Please have a look at the Makefile.common from festvox-cmu_us_slt_arctic/. If you rename pkg-plist to some other name and use this version of the Makefile.common, make check-plist will not generate any warnings.
The Makefile.common seems to work. Should I regenerate patches and poudriere logs? But I have spotted another problem: neither festlex-poslex nor festlex-cmu are pulled in by poudriere or pkg. On portlint: last time I checked, Makefile.common has proper layout of a Makefile.
No new patches needed yet. About the other issues: I have no application knowledge, so if -poslex or -cmu are needed, can you propose a fix ? Are those RUN_ or BUILD_ depends ? On the portlint issue I have to ask around.
Created attachment 163447 [details] new Makefile.common Fixed depends
Test-builds done, one problem left: The ports festvox-cmu_us_clb_arctic and festvox-cmu_us_rms_arctic fails in make check-plist, because they have empty directories left over. This looks like this: ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: @dir share/festival/lib/voices/us/cmu_us_rms_arctic_clunits/cep Error: Orphaned: @dir share/festival/lib/voices/us/cmu_us_rms_arctic_clunits/dic Error: Orphaned: @dir share/festival/lib/voices/us/cmu_us_rms_arctic_clunits/emu /lab_hlb To submitter: If those empty directories are never needed, I can try to remove them in the do-install step.
Created attachment 163694 [details] shar-final final version of shar, testbuilds@work
I guess removing those dirs should not break anything, but can not check at the moment...
Testbuilds all fine, will commit next evening (it's late here in CET)
A commit references this bug: Author: pi Date: Tue Dec 1 18:51:00 UTC 2015 New revision: 402777 URL: https://svnweb.freebsd.org/changeset/ports/402777 Log: New ports: audio/festvox-cmu_us_*_arctic Six voices for audio/festival. WWW: http://www.speech.cs.cmu.edu/ PR: 196453 Submitted by: Michael Danilov <mike.d.ft402@gmail.com> Changes: head/audio/Makefile head/audio/festvox-cmu_us_awb_arctic/ head/audio/festvox-cmu_us_awb_arctic/Makefile head/audio/festvox-cmu_us_awb_arctic/distinfo head/audio/festvox-cmu_us_awb_arctic/pkg-descr head/audio/festvox-cmu_us_awb_arctic/pkg-message head/audio/festvox-cmu_us_bdl_arctic/ head/audio/festvox-cmu_us_bdl_arctic/Makefile head/audio/festvox-cmu_us_bdl_arctic/distinfo head/audio/festvox-cmu_us_bdl_arctic/pkg-descr head/audio/festvox-cmu_us_bdl_arctic/pkg-message head/audio/festvox-cmu_us_clb_arctic/ head/audio/festvox-cmu_us_clb_arctic/Makefile head/audio/festvox-cmu_us_clb_arctic/distinfo head/audio/festvox-cmu_us_clb_arctic/pkg-descr head/audio/festvox-cmu_us_clb_arctic/pkg-message head/audio/festvox-cmu_us_jmk_arctic/ head/audio/festvox-cmu_us_jmk_arctic/Makefile head/audio/festvox-cmu_us_jmk_arctic/distinfo head/audio/festvox-cmu_us_jmk_arctic/pkg-descr head/audio/festvox-cmu_us_jmk_arctic/pkg-message head/audio/festvox-cmu_us_rms_arctic/ head/audio/festvox-cmu_us_rms_arctic/Makefile head/audio/festvox-cmu_us_rms_arctic/distinfo head/audio/festvox-cmu_us_rms_arctic/pkg-descr head/audio/festvox-cmu_us_rms_arctic/pkg-message head/audio/festvox-cmu_us_slt_arctic/ head/audio/festvox-cmu_us_slt_arctic/Makefile head/audio/festvox-cmu_us_slt_arctic/Makefile.common head/audio/festvox-cmu_us_slt_arctic/distinfo head/audio/festvox-cmu_us_slt_arctic/pkg-descr head/audio/festvox-cmu_us_slt_arctic/pkg-message
Committed, thanks for your patience!